Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5d040db-0052-7054-f55a-5928360d536d@amd.com>
Date:   Wed, 24 Aug 2022 11:48:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v3 04/10] x86/resctrl: Detect and configure Slow Memory
 Bandwidth allocation
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>, fenghua.yu@intel.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     eranian@google.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, corbet@lwn.net, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, bagasdotme@gmail.com
References: <166117559756.6695.16047463526634290701.stgit@bmoger-ubuntu>
 <166117578936.6695.16882887771401229703.stgit@bmoger-ubuntu>
 <fa6c01b8-455e-4be6-2607-985ddbd3449e@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <fa6c01b8-455e-4be6-2607-985ddbd3449e@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1dmMWxXVWh1ZmVYekVDdHFvVjJna0FsdkhmOWJjUEFXY0lCN0NobEFlUTNs?=
 =?utf-8?B?VE9LKzBYbEMzencxMHVjelpSWW1Pb3IwTHVsbEc3STZXb2lFZW5YdXNhK0pX?=
 =?utf-8?B?dUZRcWN4ZDNKOE56akcxdmxqRE5yR3BLci96M0FTdDIwNzUwNzVBbTMxMEQ0?=
 =?utf-8?B?Um5DOVlwU1N2UFl0OXhSNWViSVcvc0N4dDBlTit2blAvMVBXUnhtUTFHaURL?=
 =?utf-8?B?YXZ6aFVKd05ncU1oQmNzV2poNmNrZTJudXF3cHFsMjdFYmF4SmRaU2VkS1dD?=
 =?utf-8?B?b2htaXdzaVU4OTBnTWdueWc0STZBL3hBNGF4ZDh5cm1qMWE5TEZsTWhiVTlQ?=
 =?utf-8?B?Slhob3U3NWp0M1N3d1JmbFlZcjVUcFJlTGRqeDgwWDhiVS9Nd2xhWFlTNzdm?=
 =?utf-8?B?cXpLc3hlcUFQY21reXl5TjhBRm5TVVE0QXVxWWV2emFZY1d0U3lqSDZPejFv?=
 =?utf-8?B?eDh5QmhuYklWb0Y2bDZtcDV0V1kySURaa1Z0WHpTVDF0WktFOFVGRHJPUDAy?=
 =?utf-8?B?VXl6c0lNRmNPY2NXMHZaR2R2dGoxdFdxY1pIQlpnZVBBaUdJdFpUQmlBODVC?=
 =?utf-8?B?SmVlR1lVbWk1enVreHVZZE42UG1INTFBQkZDSE9Pcnd6dTN0OTd1ZjFRR2Vo?=
 =?utf-8?B?UVVZdHJwYkpLbStJUzZHVmk5SHBZMDNqTjJrUFg4cFhTZk56RElabFBLYWlU?=
 =?utf-8?B?WnNKa3BrYlFCZmF5NDI4MXFuVGoyNFBac3B4dXRnUGlCdis1a0JNUnRhOTR2?=
 =?utf-8?B?U1I4VGtDbkEvNkY0dUdnK1VYUTV0MlV2MUQxNGpERkliTVhzZklxZklBVEV6?=
 =?utf-8?B?b3BTaGxTQUdDQkM3cDVndlpKTXNRSGl0T1pIYVBrQUo3ZnN0QVpYajlxNnRV?=
 =?utf-8?B?WFdscGE5cXRoZGptQ1pFcUN6ZWN1VTNWOWxFMThPWXYrQlhYakxreGlHenZD?=
 =?utf-8?B?cE1TYUJFcVhIRFYxTlJOT09IakVQbzhjY1pHZmUvTzNodHIrYjlHdnJDSzU3?=
 =?utf-8?B?RUpUSXBwRVJESE9nK1dUaDVyQUxFQXMyTEdOQndpcGMrN0QyQkxqNUNTUlRD?=
 =?utf-8?B?Yk1nNGhSKy9ONlk3OXE5ODQxem13dGJiUVRlcHhtOHhsUC9XUktrMFhQS3dr?=
 =?utf-8?B?b29XVU1kaDBCejhpdmo0dDh1SDVaR3FMVkQrMEVFcGtVQ0NySkFKUkNUZDAx?=
 =?utf-8?B?SXczTThYbnVtbWp5cEJJYWdmZUZ0ZHhOZ3c0YzVPbWZQRzRPSHJhdytSNGw1?=
 =?utf-8?B?andZaGZ3WHl1ODg0YUJpbUNucXA1NmtzcWFQNzc5cE1iWjlra3ZYU04yd0x4?=
 =?utf-8?B?NVZ6R0E4TUFvZnFadVc4VEVZQ2IwczlKVlIxTXpFSkFtSWpZY2R1SVN5c1BT?=
 =?utf-8?B?TDl1YjR6VFl2eGJSU1pKYVRtRHVGNXlWcGVLTHAzNENSRlQvQkdhbXFDczRI?=
 =?utf-8?B?VUhxK3U3Umt1MWFYUkZ0RXB3bUI3WjhNbk9hRVdUMmVjR3pNSHhoVFNWWXVa?=
 =?utf-8?B?YkE3NFNRLytZVzk5NEVxOVhuU2VrT3VrNkRqK1hCYWI1OTJXSUNrUTk1a2dC?=
 =?utf-8?B?SGhMRTZkNzMvS0ZmN0lnQm5KdG5kbDlIZ2g5UHdkTiszQ2RSVjVGNXJQOFEv?=
 =?utf-8?B?ZktjeUhGNVljblY4RW5DRGlCK00rZnVmdjZZZG4xQktGanlNVHV3Nnhxa1lV?=
 =?utf-8?B?YmluWmNPTTg5WkFFV1BHK2ZPeGxVc21uTXAwVWE5S3BOREdXL20vNmp0VXhB?=
 =?utf-8?B?L1pyMEJNRVhMWm8ycWo1UjNCNHNTaitxRU5vNGp4RTFZMm1zZTJyRE1PT3dI?=
 =?utf-8?B?aTRRSUQwNlVTR2VUY2lOTkNxeXZNc1pHVjdUbFUzQUF3UCt2V1hMRTVhS29P?=
 =?utf-8?B?WjdSQ3RJMXBmL094QVRlTEhkbUFJWERKV0YwdGtlbi94b3FuSStzTklmMXM0?=
 =?utf-8?B?dzEyNjA2RDUyRGRLeXBVcVlyK0k3a1paZzYvKzAvTzRaUlZHT2kyalRkaEF3?=
 =?utf-8?B?MjhaVW13bzk3MjlBQWZYMWYwSFdJUlBKUG9kNnZmcnRzc2lKTTJHcFRnN2Y3?=
 =?utf-8?B?R0R1bEZncjNVa002YUlGVUpBL0tzb29MNEVueGNBZVR1U092dUpNVXdFdnQ5?=
 =?utf-8?Q?5CCw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6aba0f62-730f-4515-6df5-08da85f0710e
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 16:48:16.3481
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9PU//j+4xBvj/stR/6hOYBNdYd9iffdQotRzpUKekmPhsDAE7v2Femm0/+wCmCsl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7166
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Reinette,

On 8/23/22 17:47, Reinette Chatre wrote:
> Hi Babu,
>
> On 8/22/2022 6:43 AM, Babu Moger wrote:
>> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
>> index 6c38427b71a2..36ad97ab7342 100644
>> --- a/arch/x86/kernel/cpu/resctrl/core.c
>> +++ b/arch/x86/kernel/cpu/resctrl/core.c
>> @@ -253,6 +253,37 @@ static bool __rdt_get_mem_config_amd(struct rdt_resource *r)
>>  	return true;
>>  }
>>  
>> +static bool __rdt_get_s_mem_config_amd(struct rdt_resource *r)
>> +{
>> +	struct rdt_hw_resource *hw_res = resctrl_to_arch_res(r);
>> +	union cpuid_0x10_3_eax eax;
>> +	union cpuid_0x10_x_edx edx;
>> +	u32 ebx, ecx;
>> +
>> +	cpuid_count(0x80000020, 2, &eax.full, &ebx, &ecx, &edx.full);
>> +	hw_res->num_closid = edx.split.cos_max + 1;
>> +	r->default_ctrl = MAX_MBA_BW_AMD;
>> +
>> +	/* AMD does not use delay */
>> +	r->membw.delay_linear = false;
>> +	r->membw.arch_needs_linear = false;
>> +
>> +	/*
>> +	 * AMD does not use memory delay throttle model to control
>> +	 * the allocation like Intel does.
>> +	 */
>> +	r->membw.throttle_mode = THREAD_THROTTLE_UNDEFINED;
>> +	r->membw.min_bw = 0;
>> +	r->membw.bw_gran = 1;
>> +	/* Max value is 2048, Data width should be 4 in decimal */
>> +	r->data_width = 4;
>> +
>> +	r->alloc_capable = true;
>> +	r->alloc_enabled = true;
>> +
>> +	return true;
>> +}
>> +
>
> From what I can tell this new function is almost identical to (it differs with
> one character from) __rdt_get_mem_config_amd(). Could it be refactored to
> avoid such duplication?

Yes. Sure. We can do that.

Thanks