Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp928172rwe; Wed, 24 Aug 2022 11:25:44 -0700 (PDT) X-Google-Smtp-Source: AA6agR7WUngO33v3DXIWSZ3hjEl8iS4u1vLXOCRpDl8OaaAzHvBECAOHl0lfCIH6rd4f0aIxWlPq X-Received: by 2002:aa7:dc0d:0:b0:443:e1ca:bdb1 with SMTP id b13-20020aa7dc0d000000b00443e1cabdb1mr270966edu.62.1661365544063; Wed, 24 Aug 2022 11:25:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661365544; cv=none; d=google.com; s=arc-20160816; b=pk8c606fLYFq940Fp+msZzbSSBi/hRh/jZFvtwy0NytIddZx3LSHj+FAWCmyPMfopy jyyOIBkwf1JgfB/40LlDhk/UHewy3D2yXTanwliWbzmYPF4GhnbsaBRtVdQlyJAgY2ri 9I9+wKpCfyD0li8Z2Nno8pupGsnE9FWCtqKsjlgyK+8+6ROnY3B0srQGd8Zq7Bi8b8MP mQgJMP4UHMezY9jSH6ZNNU+4zBW/UL+M2vXpEUvsxLP3YZOm89kp/cdsEwE+8dY0wmc1 JSTaEEnwfTGFwZX5rXd0q5UgqMvscm5195SFgpNIh+ug97nUZD4mFm3pVwuShxxhy6K8 7cJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=iLo/HCTUWn+r4ClX2zkFEpZpMUcQ5Z6K4CQx3YllaL4=; b=UlGveM+8BnUULkZbQ4i3ZimFDbji25H6lqvDakT8D3HnkAM34KRDu+kcsLvLPDpimr y8zG9RumN/C3KN3UunciUjccwbP/l6Hy1Ubyma3h6NxdWrfevW59259r3vnUa+bKJrUQ HQMZN7B8OgEhTcY27mbFIR8GOs8oPIqMuRzKbG1HxNfsq+jVNirETlyJTjEbhsI2WKZh X1m/A2mP/EXgJmO7t2n+EFP0Pl3rTKNh2P6sI7EWsZga0RwHbPOmieXcYfaRZbQiU02r DRfi+6XUB9dRgX/dNW1AfXijdBKDDfcNcNfokWtaYNoys7CqKlckB2I9xWGCC6BEOGhg LH6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=CjlbdjlR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd30-20020a170907629e00b0073da19d0cd2si2585441ejc.737.2022.08.24.11.25.18; Wed, 24 Aug 2022 11:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=CjlbdjlR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240270AbiHXR6c (ORCPT + 99 others); Wed, 24 Aug 2022 13:58:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239804AbiHXR6X (ORCPT ); Wed, 24 Aug 2022 13:58:23 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AF6F4D4C1 for ; Wed, 24 Aug 2022 10:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iLo/HCTUWn+r4ClX2zkFEpZpMUcQ5Z6K4CQx3YllaL4=; b=CjlbdjlRZ6PbkFyMA53XjRWugt mRuxsV+xEm4U5jy65XZhmqiBIir7W6kdxYKGDzKHxi5uvjPtB7bisDHZOOg+A/xmkybE1lCEJRGmZ iIaixY9hLKkORxtgyDoZ3Qy4t9HtPCg+xjcWcKAn5uATAzz/kaUwf+P1WH2Y9TS6etJYOPeBFqtSb UN0GIWSkIcDI7NEfoqYhjBLUILZUSivdSul8r2HbshXKMBzk6vv+zkVD8B7tvUz1QttTP6SVOLGpV D3eiPTypaxi6yfCGKKg5ujZONGxwXUUKxv/nq7CXu9xlmbOlWYrVnWe+0vrJplxgiNcK3lvLigCuC xJ23rrPQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33916) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oQudq-0004PL-On; Wed, 24 Aug 2022 18:58:14 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oQudm-0004L7-QO; Wed, 24 Aug 2022 18:58:10 +0100 Date: Wed, 24 Aug 2022 18:58:10 +0100 From: "Russell King (Oracle)" To: Yury Norov Cc: Andy Shevchenko , Linus Torvalds , Linux Kernel Mailing List , Guenter Roeck , Dennis Zhou , Catalin Marinas , Andy Shevchenko , Rasmus Villemoes , Alexey Klimov , Kees Cook , Andy Whitcroft Subject: Re: [PATCH v2 2/3] lib/find_bit: create find_first_zero_bit_le() Message-ID: References: <20220824012624.2826445-1-yury.norov@gmail.com> <20220824012624.2826445-3-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2022 at 06:37:45AM -0700, Yury Norov wrote: > Because there is a codebase that relies on existing types, mostly in > filesystem code. And those fs fixes would require 5 or 6 patches. Does that mean that are there filesystems that are passing pointers to the find_bit functions which are _not_ aligned to an "unsigned long" ? If there are, we should _not_ convert 32-bit ARM to use word loads or use the generic code; unaligned loads are expensive on older ARM CPUs, at least not the code for older ARM CPUs. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!