Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp941143rwe; Wed, 24 Aug 2022 11:41:26 -0700 (PDT) X-Google-Smtp-Source: AA6agR5LSgc5iVSDS2WmITL38fIw0Bczzn2DJJbg+N/3VsQaQo9x9GB6yflJtRrirF8bn2TWO2zb X-Received: by 2002:a05:6a00:99b:b0:536:754a:ab31 with SMTP id u27-20020a056a00099b00b00536754aab31mr481474pfg.45.1661366486691; Wed, 24 Aug 2022 11:41:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661366486; cv=none; d=google.com; s=arc-20160816; b=RQIpizkGi7STYfwp0nDNfslxTSczw2hTnSfuKsNl5p6OIaIPPpmYewziUbIm7RiUFC H9Bkd3BJmCKVoibP19iYTHOwu2a4itX0usKz8L+XDFj6/uQQ23T4SvCNUQErIisok2x8 eA7D+mpbFQnoeJRAUtEFwXTGwLA9yj2t6r8a2Gp47QrgPbj0SvhsHturuAlwbOkuL6gx /iz9kuBxXsaktETQVOle4b/XZZOAbXdjeIeZLZR/gCRiTbhgURNrXHYjDYi1+/umSdti WsXCa1/4VOzmPkSwp3FUKbzlc63UJqVci/IaUvTT96e5MS9B6s/NBA5Vlt0SEBxi7x2a b+CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=xEBM4kjEZOw0+N/a388Pxl/h1iy9v5FJg44hVn74990=; b=dxlTdK17mgkmpRKSup2XdrDTgAtIp5q+fiU+A23xNP9BNi3iy2azpxzcH+ePI3JTf0 5sAtPfl2OCQCPlZ79AzQ78LOR4dUGnClzobxCNwYhKUYk0Wra8XkLfnf7FiAppr8Zb3Y b/onYSPqUd7DY23mAq0N6iRGw5Kx638ezeoYfawtOJphMmI8OWrvqaTI+3NWiOyF7Xlr BwowF/aTQIrhV1Sjx0j2Wgi0cCXAEQ+Ksp9ZtWpgJGyhGHL53j/Y1ufjizlYniLH6mNm NcNDHFbs18BOH2+Vb5MEEdNzz6BRiH0qhFDQg2S1PQnbH8rLG2aVAzGxhNM7kjB6PtDF 2U0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t11-20020a170902e1cb00b00172f3212febsi6588671pla.89.2022.08.24.11.41.13; Wed, 24 Aug 2022 11:41:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240223AbiHXRik (ORCPT + 99 others); Wed, 24 Aug 2022 13:38:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbiHXRii (ORCPT ); Wed, 24 Aug 2022 13:38:38 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5674A75CFF; Wed, 24 Aug 2022 10:38:37 -0700 (PDT) Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1oQuKp-0003SH-1M; Wed, 24 Aug 2022 19:38:35 +0200 Received: from [85.1.206.226] (helo=linux-4.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQuKo-000WoJ-Kg; Wed, 24 Aug 2022 19:38:34 +0200 Subject: Re: [PATCH v3 0/4] bpf: Add user-space-publisher ringbuffer map type To: David Vernet , bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org Cc: kernel-team@fb.com, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, joannelkoong@gmail.com, tj@kernel.org, linux-kernel@vger.kernel.org References: <20220818221212.464487-1-void@manifault.com> From: Daniel Borkmann Message-ID: <81eff27a-652b-4b55-7a4a-31c421b7f0bb@iogearbox.net> Date: Wed, 24 Aug 2022 19:38:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20220818221212.464487-1-void@manifault.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.6/26637/Wed Aug 24 09:53:01 2022) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey David, On 8/19/22 12:12 AM, David Vernet wrote: > This patch set defines a new map type, BPF_MAP_TYPE_USER_RINGBUF, which > provides single-user-space-producer / single-kernel-consumer semantics over > a ringbuffer. Along with the new map type, a helper function called > bpf_user_ringbuf_drain() is added which allows a BPF program to specify a > callback with the following signature, to which samples are posted by the > helper: Looks like this series fail BPF CI, ptal: https://github.com/kernel-patches/bpf/runs/7996821883?check_suite_focus=true [...] bpftool_checks - Running bpftool checks... Comparing /tmp/work/bpf/bpf/tools/include/uapi/linux/bpf.h (bpf_map_type) and /tmp/work/bpf/bpf/tools/bpf/bpftool/map.c (do_help() TYPE): {'user_ringbuf'} Comparing /tmp/work/bpf/bpf/tools/include/uapi/linux/bpf.h (bpf_map_type) and /tmp/work/bpf/bpf/tools/bpf/bpftool/Documentation/bpftool-map.rst (TYPE): {'user_ringbuf'} bpftool checks returned 1. [...]