Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220824152420.20547-1-bp@alien8.de> <20220824172929.GA25951@gate.crashing.org>
In-Reply-To: <20220824172929.GA25951@gate.crashing.org>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Wed, 24 Aug 2022 11:44:35 -0700
Message-ID: <CAKwvOdm+yFhZ2pYLJ5vpj1YyNJmG=UVF4cTz_m+0UfDGNGsRbQ@mail.gmail.com>
Subject: Re: [PATCH] x86/sev: Mark snp_abort() noreturn
To:     Segher Boessenkool <segher@kernel.crashing.org>
Cc:     Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>,
        Michael Matz <matz@suse.de>, linux-toolchains@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Aug 24, 2022 at 10:33 AM Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>
> Hi!
>
> On Wed, Aug 24, 2022 at 05:24:20PM +0200, Borislav Petkov wrote:
> > Mark both the function prototype and definition as noreturn in order to
> > prevent the compiler from doing transformations which confuse objtool
> > like so:
> >
> >   vmlinux.o: warning: objtool: sme_enable+0x71: unreachable instruction
>
> Would -Wmissing-noreturn have caught this?

Oh, that's shiny. Is that relatively new?
-- 
Thanks,
~Nick Desaulniers