Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c6d89f21-b914-a7c1-d34c-dd083185d18b@intel.com>
Date:   Wed, 24 Aug 2022 11:53:49 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] x86/sev: Don't use cc_platform_has() for early SEV-SNP
 calls
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     Tom Lendacky <thomas.lendacky@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Asish Kalra <ashish.kalra@amd.com>,
        Michael Roth <michael.roth@amd.com>,
        Joerg Roedel <jroedel@suse.de>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        stable@vger.kernel.org, Sean Christopherson <seanjc@google.com>
References: <0c9b9a6c33ff4b8ce17a87a6c09db44d3b52bad3.1661291751.git.thomas.lendacky@amd.com>
 <10bc452f-3564-e41b-836d-e135a8f4260d@intel.com> <YwZyjE6BmnvxHXcR@zn.tnic>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <YwZyjE6BmnvxHXcR@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/24/22 11:48, Borislav Petkov wrote:
> On Wed, Aug 24, 2022 at 11:43:10AM -0700, Dave Hansen wrote:
>> So, we don't have *ANY* control over where the compiler uses jump
>> tables.  The kernel just happened to add some code that uses them, fell
>> over, and this adds a hack to get booting again.
>>
>> Isn't this a bigger problem?
> I had the same question already. Was thinking of maybe disabling
> the compiler from producing jump tables in the ident-mapped code.
> Tom's argument is that that might prevent the compiler from doing
> optimizations but I haven't talked to compiler folks whether those
> optimizations are even worth the effort.
> 
> Regardless, the potential problem is limited:
> 
> "# (jump-tables are implicitly disabled by RETPOLINE)"

Ahh, I missed the connection with retpoline.  The ubiquity of
RETPOLINE=y probably means we'll see more of these issues because people
won't find them unless they're building and running weirdo configurations.

> i.e., only RETPOLINE=n builds for now which should be a minority?
> 
> I guess when this explodes somewhere else again, we will have to
> generalize a fix.

Yep.  It also reminds me to add RETPOLINE=n build to my tests.