Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <559e9805-3e38-fa50-d3ce-5eee317832bf@gmx.de>
Date:   Wed, 24 Aug 2022 21:20:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH -next] parisc: ccio-dma: Add missing iounmap in error path
 in ccio_probe()
Content-Language: en-US
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Cc:     liqiong@nfschina.com
References: <20220824093657.3365027-1-yangyingliang@huawei.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220824093657.3365027-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 8/24/22 11:36, Yang Yingliang wrote:
> Add missing iounmap() before return from ccio_probe(), if ccio_init_reso=
urces()
> fails.
>
> Fixes: d46c742f827f ("parisc: ccio-dma: Handle kmalloc failure in ccio_i=
nit_resources()")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

applied.
Thanks!
Helge


> ---
>  drivers/parisc/ccio-dma.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
> index f223afe47d10..a66386043aa6 100644
> --- a/drivers/parisc/ccio-dma.c
> +++ b/drivers/parisc/ccio-dma.c
> @@ -1546,6 +1546,7 @@ static int __init ccio_probe(struct parisc_device =
*dev)
>  	}
>  	ccio_ioc_init(ioc);
>  	if (ccio_init_resources(ioc)) {
> +		iounmap(ioc->ioc_regs);
>  		kfree(ioc);
>  		return -ENOMEM;
>  	}