Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b696b6cc-7cd4-4f62-6289-6f29c1e40214@gmx.de>
Date:   Wed, 24 Aug 2022 21:56:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] video: fbdev: omap: Remove unnecessary print function
 dev_err()
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20220824114455.5167-1-jiapeng.chong@linux.alibaba.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220824114455.5167-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 8/24/22 13:44, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/video/fbdev/omap/omapfb_main.c:1653:2-9: line 1653 is redundan=
t because platform_get_irq() already prints an error.
> ./drivers/video/fbdev/omap/omapfb_main.c:1646:2-9: line 1646 is redundan=
t because platform_get_irq() already prints an error.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D1957
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

applied.

Thanks!
Helge

> ---
>  drivers/video/fbdev/omap/omapfb_main.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbde=
v/omap/omapfb_main.c
> index fbb3af883d4d..17cda5765683 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1643,14 +1643,12 @@ static int omapfb_do_probe(struct platform_devic=
e *pdev,
>  	}
>  	fbdev->int_irq =3D platform_get_irq(pdev, 0);
>  	if (fbdev->int_irq < 0) {
> -		dev_err(&pdev->dev, "unable to get irq\n");
>  		r =3D ENXIO;
>  		goto cleanup;
>  	}
>
>  	fbdev->ext_irq =3D platform_get_irq(pdev, 1);
>  	if (fbdev->ext_irq < 0) {
> -		dev_err(&pdev->dev, "unable to get irq\n");
>  		r =3D ENXIO;
>  		goto cleanup;
>  	}