Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1417f4ce-2573-5c88-6c92-fda5c57ebceb@intel.com>
Date:   Wed, 24 Aug 2022 13:29:03 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.12.0
Subject: Re: [PATCH] dmaengine: idxd: Set workqueue state to disabled before
 trying to re-enable
Content-Language: en-US
To:     Jerry Snitselaar <jsnitsel@redhat.com>,
        linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>,
        dmaengine@vger.kernel.org
References: <20220824192913.2425634-1-jsnitsel@redhat.com>
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20220824192913.2425634-1-jsnitsel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/24/2022 12:29 PM, Jerry Snitselaar wrote:
> For a software reset idxd_device_reinit() is called, which will walk
> the device workqueues to see which ones were enabled, and try to
> re-enable them. It keys off wq->state being iDXD_WQ_ENABLED, but the
> first thing idxd_enable_wq() will do is see that the state of the
> workqueue is enabled, and return 0 instead of attempting to issue
> a command to enable the workqueue.
>
> So once a workqueue is found that needs to be re-enabled,
> set the state to disabled prior to calling idxd_enable_wq().
> This would accurately reflect the state if the enable fails
> as well.
>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
> Fixes: bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data accelerators")
> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
> ---
>   drivers/dma/idxd/irq.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index 743ead5ebc57..723eeb5328d6 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -52,6 +52,7 @@ static void idxd_device_reinit(struct work_struct *work)
>   		struct idxd_wq *wq = idxd->wqs[i];
>   
>   		if (wq->state == IDXD_WQ_ENABLED) {
> +			wq->state = IDXD_WQ_DISABLED;
Might be better off to insert this line in idxd_wq_disable_cleanup(). I 
think that should put it in sane state.
>   			rc = idxd_wq_enable(wq);
>   			if (rc < 0) {
>   				dev_warn(dev, "Unable to re-enable wq %s\n",