Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220823131629.RFT.1.I137e6bef4f6d517be7b081be926059321102fd3d@changeid>
 <20220823221429.3bte2tgtyniur4wb@halaneylaptop> <CAD=FV=WSSrObW2PthmUL+t=VYJ+mN6Z763pozCQDbOdPtAXyQA@mail.gmail.com>
 <YwVZfyDflFuzFAOX@sirena.org.uk>
In-Reply-To: <YwVZfyDflFuzFAOX@sirena.org.uk>
From:   Doug Anderson <dianders@chromium.org>
Date:   Wed, 24 Aug 2022 14:24:28 -0700
Message-ID: <CAD=FV=XZTzwROoVtA+qrpy5rrrM2RH3+tZFR0-KFTu79ea4rig@mail.gmail.com>
Subject: Re: [RFT PATCH] regulator: core: Require regulator drivers to check
 uV for get_optimum_mode()
To:     Mark Brown <broonie@kernel.org>
Cc:     Andrew Halaney <ahalaney@redhat.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Tue, Aug 23, 2022 at 3:49 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Aug 23, 2022 at 03:32:44PM -0700, Doug Anderson wrote:
>
> > I guess maybe we could add the "initial mode" as an implicitly allowed
> > mode? I guess the other option is to implicitly disable
> > regulator-allow-set-load if no allowed modes are listed? Both of these
>
> We should do the former, or equivalently just noop out of set_load() via
> set_optimium_mode() if no modes are allowed.

OK, v2 posted where I kept patch #1 exactly the same and added a
second patch to address this case. Hopefully it works for you.

-Doug