Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 Aug 2022 14:52:51 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Shiyang Ruan <ruansy.fnst@fujitsu.com>,
        <linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
        <nvdimm@lists.linux.dev>, <linux-mm@kvack.org>,
        <linux-fsdevel@vger.kernel.org>
CC:     <djwong@kernel.org>, <dan.j.williams@intel.com>,
        <david@fromorbit.com>, <hch@infradead.org>,
        <akpm@linux-foundation.org>, <jane.chu@oracle.com>,
        <rgoldwyn@suse.de>, <viro@zeniv.linux.org.uk>,
        <willy@infradead.org>, <naoya.horiguchi@nec.com>,
        <linmiaohe@huawei.com>, Christoph Hellwig <hch@lst.de>
Subject: RE: [PATCH v2 05/14] mm: Introduce mf_dax_kill_procs() for fsdax case
Message-ID: <63069db388d43_1b3229426@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220603053738.1218681-1-ruansy.fnst@fujitsu.com>
 <20220603053738.1218681-6-ruansy.fnst@fujitsu.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220603053738.1218681-6-ruansy.fnst@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?my1MbgzNsBW0d5h2ausbcBNnLyipRcL1JQcL07nEEPJuTEoNX+l2eBR/pKDv?=
 =?us-ascii?Q?jkXBYbcAIeqdHVq46ab8yLEkh5gYgB3CDXJHeyXfmfC+ZZgAoAYYIVXiYgJg?=
 =?us-ascii?Q?5Ynb7pjybhU9yPSz3ZnnmfIZaducevSvUX/3RxIWDqmcHHQFFt044FKhHH9j?=
 =?us-ascii?Q?ewVcDNvhuq+SYNxN2y/+5pkYuN3CROrbQDje5YH58WaoikEAffG3byzrMKFx?=
 =?us-ascii?Q?MwFQYInm6WDes+H68QNvWKXiSI3TRV/+j5TDubTdCc9mziSK5DMyXlhOCUq+?=
 =?us-ascii?Q?k56vBuaR8meQ9rM+QywP3fpaW6JZFLCiPT617SwE9wGdD8wLO8pajVuA9dt2?=
 =?us-ascii?Q?W/x2ijPOOpLkNtKZB3d7SGSEHeGM3QhsIU663nXuuljzbMcRA9qoq8I7v/qj?=
 =?us-ascii?Q?dJwKplgDRytBpwvyEO/t72SzCQzUuNnc8rA8YnUmHXikdjhnoQGbaC575h18?=
 =?us-ascii?Q?NNXbwQ9R1kpixfjXQXc0HkfwgVNs1/QN0HfQYOGlbQ6HalYsov4QjvMftkyr?=
 =?us-ascii?Q?tRL6dJICBTug61jqO+T8ZvkyITHzFEthKUgy/vCG5y34i7ga102RkXtZ0Q/K?=
 =?us-ascii?Q?oLiV+FA/pRcku3vreLyjfe37RJveWouyaYwNQCoy+gInCVCcStEgTqiNWy/m?=
 =?us-ascii?Q?S77PTpRver4EJo8sKw0m9RjZ37pqvuF3UegkgTgC/XO0FZ3bWveJbcqOsGqu?=
 =?us-ascii?Q?KjbTzaktTfQliRLoEm87uy6iovXazE70R1lI8fo5xqiI3gRmqo8FJH5LVIRH?=
 =?us-ascii?Q?+mdmqmLOJwl4wDQcel1MErTwChLS4yufPIX4NYgfFwXB0Baq4CkyugFT5+WZ?=
 =?us-ascii?Q?l+t98kAnG3o+KRFd+eEx/w5p2sU4/Aydnkpo/jXMNY7s72kM8EWMujjfttcv?=
 =?us-ascii?Q?38QmpD+n28MDzqJykTfyE3P+7UENunjQJMoLTzhl0uy2c/niuLT5eSd4MROM?=
 =?us-ascii?Q?bkNJJLkc6rkFFOvxajThrr3do26zLkFbs804jK1sWy8VR6LByPrOGux7oVM1?=
 =?us-ascii?Q?lcR3VqvnkMSCJeAHC2/G8q7CnMWVHcvdBSGKijtSyRqzWZzwOslUZHEVJhi0?=
 =?us-ascii?Q?CFWFfJZ86kmKKkDQUv0MsCB7K8pj8q5R3BUBZSfYKyq2r6U16E0ZCmg2FtfN?=
 =?us-ascii?Q?DEjMWWsdHp368f7Vo6d3L5kU3oPVDu+NtMEEH74tw9vCKNTMCumZDURq9Hnk?=
 =?us-ascii?Q?i3PwnaNG8HSgZSDm4DEgiwILi7vCnRa3z2VUqdvmJsiUiBENA9st9HEjdD8r?=
 =?us-ascii?Q?Fp0QsPWBP5wANyhLCSkPF0uM1lgXIM5GvW8TCWjrmjqhALv2Y1ks0EmQlDnV?=
 =?us-ascii?Q?KwPx7qIIJaphKobVWlVUoeLGndHyWqVceI0RnD3XC8RZgZg0eeDftMOTHiNC?=
 =?us-ascii?Q?V6OFIxwEke9XfTco4dRxJQ/IEJnu+WQwHOg+DAg3IlhW1ohPPPCuJoww1HKw?=
 =?us-ascii?Q?kMo4UA4xyxXVmVQbmh4SaDvgwicFUdVExgO2/YtrYGoGiV1A1zLt8FPsn6Lv?=
 =?us-ascii?Q?n5yvEEjo2fVrp2xoayPsmzqjy2WDYlQqZmj9Sx0Ee3qUDgwca4KHctXinVC0?=
 =?us-ascii?Q?cXcvixGBYGwq9B1bhnRKx79u2s2RAMXujJuLZs+ou9tkUYuiOtGY9zwD8e1x?=
 =?us-ascii?Q?Bg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b343e05-a21a-406e-f693-08da861affeb
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 21:52:54.9772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aI4eWdZ4Y7+ik93Nszl9P8tDAQawO8vteuIYE6NEJ/SfX+09iYTAT/ByXABDKzmWikIz83yh6NHmmDKRA3Zr07ABzVc02NF02udS75MTmaQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5867
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Shiyang Ruan wrote:
> This new function is a variant of mf_generic_kill_procs that accepts a
> file, offset pair instead of a struct to support multiple files sharing
> a DAX mapping.  It is intended to be called by the file systems as part
> of the memory_failure handler after the file system performed a reverse
> mapping from the storage address to the file and file offset.
> 
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  include/linux/mm.h  |  2 +
>  mm/memory-failure.c | 96 ++++++++++++++++++++++++++++++++++++++++-----
>  2 files changed, 88 insertions(+), 10 deletions(-)

Unfortunately my test suite was only running the "non-destructive" set
of 'ndctl' tests which skipped some of the complex memory-failure cases.
Upon fixing that, bisect flags this commit as the source of the following
crash regression:

 kernel BUG at mm/memory-failure.c:310!
 invalid opcode: 0000 [#1] PREEMPT SMP PTI
 CPU: 26 PID: 1252 Comm: dax-pmd Tainted: G           OE     5.19.0-rc4+ #58
 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
 RIP: 0010:add_to_kill+0x304/0x400
[..]
 Call Trace:
  <TASK>
  collect_procs.part.0+0x2c8/0x470
  memory_failure+0x979/0xf30
  do_madvise.part.0.cold+0x9c/0xd3
  ? lock_is_held_type+0xe3/0x140
  ? find_held_lock+0x2b/0x80
  ? lock_release+0x145/0x2f0
  ? lock_is_held_type+0xe3/0x140
  ? syscall_enter_from_user_mode+0x20/0x70
  __x64_sys_madvise+0x56/0x70
  do_syscall_64+0x3a/0x80
  entry_SYSCALL_64_after_hwframe+0x46/0xb0

This is from running:

  meson test -C build dax-ext4.sh

...from the ndctl repo.

I will take look, and posting it here in case I do not find it tonight
and Ruan can take a look.