Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: ASUSXdBlYB4qf6gwVPic8bfzRH3IUqenZnzQeuJNR/2xl45TXN0qSmaSAuidjeYVXBkHHd34ot
 96BTV+Utdg3NUHh4YftjyJ+TIe8W9ZSKiPgA2UNmu8jy3lujOIrjbV066ZtBIgcbU3SSLpQkPk
 Y8Xsf1kDHUSqkVMk4iKJhpUuob/44HG+RpDcAdSIEYLHyYL7u65XdneCMokRJSzJPuGl6SBwrp
 Ne7EYlMMHGOy3aJgMCVWUd0lOvwnRaYXPM+6orbqfVoxvn8GlyaFF3N6sUeDFVvrLtfXbz3NuD
 TmEUxuJO6lID3FgvxPyDh8Tx
IronPort-SDR: XpkaOFRaRbywAf229PsraJXJMMuJDgm8pWm2YRd/gZDZNMxZZLSPtx1x5Qb9X4n4KAlgd8X8XF
 Eq6VI/7/2Xrw/XCzxeGzS521h62HesGYpld2v2qdOi0RumGFYAogEAaGha/sGVWquQrgwrGrEj
 uD//nK/G/XbPskxM67+Uzj6AsknFZkL4iJ87sRQQidmfTKurkw2DxuuTM0H4mAOAh04KoPwGBT
 XEobk9hvlBiR2w9u7uhgJaIC+BRhBlPhRNRtQDpQFIWoVjGlWS511acgCkD2NuOT4/WU87yHXD
 6qE=
WDCIronportException: Internal
Message-ID: <5b7fe985-6e5a-1d26-dc48-ac5000929e94@opensource.wdc.com>
Date:   Wed, 24 Aug 2022 17:13:36 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.12.0
Subject: Re: [PATCH] ATA: ACPI: Do not check ACPI_FADT_LOW_POWER_S0
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     linux-ide@vger.kernel.org, Linux ACPI <linux-acpi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <4426478.LvFx2qVVIh@kreacher>
 <9c479bb6-bb57-9b5a-2fa5-7b4d1b840245@opensource.wdc.com>
 <0b70fc12-6217-147f-c663-a1035738cf7d@amd.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <0b70fc12-6217-147f-c663-a1035738cf7d@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/08/24 16:55, Mario Limonciello wrote:
> On 8/24/22 18:54, Damien Le Moal wrote:
>> On 2022/08/24 10:29, Rafael J. Wysocki wrote:
>>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>> The patch title should be "ata: ahci: ..."
>>
>>>
>>> The ACPI_FADT_LOW_POWER_S0 flag merely means that it is better to
>>> use low-power S0 idle on the given platform than S3 (provided that
>>> the latter is supported) and it doesn't preclude using either of
>>> them (which of them will be used depends on the choices made by user
>>> space).
>>>
>>> For this reason, there is no benefit from checking that flag in
>>> ahci_update_initial_lpm_policy().
>>>
>>> First off, it cannot be a bug to do S3 with policy set to either
>>> ATA_LPM_MIN_POWER_WITH_PARTIAL or ATA_LPM_MIN_POWER, because S3 can be
>>> used on systems with ACPI_FADT_LOW_POWER_S0 set and it must work if
>>> really supported, so the ACPI_FADT_LOW_POWER_S0 check is not needed to
>>> protect the S3-capable systems from failing.
>>>
>>> Second, suspend-to-idle can be carried out on a system with
>>> ACPI_FADT_LOW_POWER_S0 unset and it is expected to work, so if setting
>>> policy to either ATA_LPM_MIN_POWER_WITH_PARTIAL or ATA_LPM_MIN_POWER is
>>> needed to handle that case correctly, it should be done regardless of
>>> the ACPI_FADT_LOW_POWER_S0 value.
>>>
>>> Accordingly, drop the ACPI_FADT_LOW_POWER_S0 check from
>>> ahci_update_initial_lpm_policy().
>>>
>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>> ---
>>>   drivers/ata/ahci.c |    3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> Index: linux-pm/drivers/ata/ahci.c
>>> ===================================================================
>>> --- linux-pm.orig/drivers/ata/ahci.c
>>> +++ linux-pm/drivers/ata/ahci.c
>>> @@ -1610,8 +1610,7 @@ static void ahci_update_initial_lpm_poli
>>>   	}
>>>   
>>>   #ifdef CONFIG_ACPI
>>> -	if (policy > ATA_LPM_MED_POWER &&
>>> -	    (acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0)) {
>>> +	if (policy > ATA_LPM_MED_POWER) {
> 
> If making this change, perhaps the #ifdef CONFIG_ACPI can drop too.

Indeed.

> 
>>>   		if (hpriv->cap & HOST_CAP_PART)
>>>   			policy = ATA_LPM_MIN_POWER_WITH_PARTIAL;
>>>   		else if (hpriv->cap & HOST_CAP_SSC)
>>>
>>>
>>>
>>
>>
> 


-- 
Damien Le Moal
Western Digital Research