Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 01:34:32 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Liam Howlett <liam.howlett@oracle.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>
Cc:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 57/70] mm/mlock: use vma iterator and maple state
 instead of vma linked list
Message-ID: <YwbDmKyQxWHfRg97@sirena.org.uk>
References: <20220822150128.1562046-1-Liam.Howlett@oracle.com>
 <20220822150128.1562046-58-Liam.Howlett@oracle.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3kTHvGW/5bDFz7Zb"
Content-Disposition: inline
In-Reply-To: <20220822150128.1562046-58-Liam.Howlett@oracle.com>
Precedence: bulk


--3kTHvGW/5bDFz7Zb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 22, 2022 at 03:06:30PM +0000, Liam Howlett wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>=20
> Handle overflow checking in count_mm_mlocked_page_nr() differently.

Our QA team found that since next-20220823 we're seeing a couple of test
failures in the check_mmap_options kselftest on arm64 platforms with MTE
that aren't present in mainline:

# # FAIL: mprotect not ignoring clear PROT_MTE property
# not ok 21 Check clear PROT_MTE flags with private mapping, sync error mod=
e and mmap memory
# # FAIL: mprotect not ignoring clear PROT_MTE property
# not ok 22 Check clear PROT_MTE flags with private mapping and sync error =
mode and mmap/mprotect memory

I bisected this using qemu[1] which landed on 4ceb4bca479d41a
("mm/mprotect: use maple tree navigation instead of vma linked list"),
though I'm not 100% sure I trust the specific identification of the
commit I'm pretty confident it's at the very least in this series.  I've
not done any analysis of the failure beyond getting this bisect result.

[1] qemu -smp cpus=3D4 -cpu max -machine virt,gic-version=3D3,mte=3Don

--3kTHvGW/5bDFz7Zb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMGw5cACgkQJNaLcl1U
h9CETwf+LuiyCa2vnhNkK0FYpnS/7LqL3rzOSWV7goeH7LToVBr2BjbzSjnGlxIO
BJ9L4MP6RC8a/0ss3fPm36g/IwOB/aSaHfsmseWji86aUFb6XonfAKj6qugMsNwe
LWEcjrMSj3RSLXfNfAdI0M0OLBfJ04VkFLrJABQYl48Yrb2QwMQlvgWvwSokHM84
f5QNWnlcvS1o58/QVZhwn7kk/JvFVIrX3Fuiae6L+nLSfEVPCeOwJohjyCZB9+3m
z7YIA89zBRIeVJUpDIGvGKHAX8RovKSrlMWKsW8vhbffjp4c7Td9VYG3wP7GfFAU
t3xQm17IiUShPZga22HlekJlUr+USg==
=DFuJ
-----END PGP SIGNATURE-----

--3kTHvGW/5bDFz7Zb--