Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp121562rwe; Wed, 24 Aug 2022 18:40:34 -0700 (PDT) X-Google-Smtp-Source: AA6agR7q3HFjmhd98FxcgIVYwYixvIbYIbi4nTrCAckMERvfzXAkfgskxVguNy4TaQXMlV5Qn5Wj X-Received: by 2002:a17:903:32d2:b0:172:f62a:2f33 with SMTP id i18-20020a17090332d200b00172f62a2f33mr1672316plr.16.1661391632790; Wed, 24 Aug 2022 18:40:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661391632; cv=none; d=google.com; s=arc-20160816; b=jC3oGDBcAM097vitKOOHL5vDIZ45n5zfDrxMNKQd7+tkAiCnwsZKBm+h6qR5eKwtMN 0xxw1IgFefPX9groyqFSnoVEqlniJfYUP+2/Hb62HhffpkiH22AinsW+6bKmlYM41OV4 pR+yBM6yiWJq1aQc1nOmcSFur1GL2JoLBO+m/VHDblj6NvJI0awPmon4IShQHBB3OR4L +ppISVuNwV9Nppe4P0F2KordL0zUa3cj/icVD/i46lkajRepDCNdGPqbGFML2WkNmTXY cwhcNaOkRzqS5z3Xz8yHhU/QMQ1A6J2Kv0ZhbGO43jtMc9ZE9A0fU3jqIM1q14EcyTXk lHug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HKpOiaVPgiuk4GojO28gGW0KJCIZrodlY4HYPSfLbuQ=; b=KO0oTUSDom6dJpRRTOar1b4cM1UGw8PO3Qy7wSuasyFzUDc6Jz7MgQjWZzoBzIZvnF 4gISghxr16BESOPE2Y9E0prZei6NXHGubJ1Zwko/S2iDOtgsSXs0wwyZlB4tIfmN1Hcz xi0vi4PA3Hy+P0iDcAMzxLaYzAigQgLrT7zBBdtvc86T6qV6AACH1tqBi/ZjarsRw5Ka DvF5o6GAedRhoAwjXSELsmjD71T5UpBZ3lbV2bqxRvidC4GcZxa9Wg2kNZMSKv0eNiJ3 SzScALddX53divuo30UkC1QY7vDMr++HAMyHUPGlcMiQ6H8kVhlpPiAVR1jWX4tdNjmF 7InQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ahEDUsFi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ct14-20020a056a000f8e00b00536a53b34a5si9247563pfb.262.2022.08.24.18.40.21; Wed, 24 Aug 2022 18:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ahEDUsFi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231938AbiHYB3I (ORCPT + 99 others); Wed, 24 Aug 2022 21:29:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230268AbiHYB3G (ORCPT ); Wed, 24 Aug 2022 21:29:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30F2D7E816; Wed, 24 Aug 2022 18:29:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D3758B824CF; Thu, 25 Aug 2022 01:29:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09570C433D6; Thu, 25 Aug 2022 01:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661390943; bh=zS7qPS6Vu0zW4YUqfCMKTSO52Y+PkYAPdsGESbX5r2M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ahEDUsFiYyy/b5oYgueRM7g4wilFFkA+yojrDkIArZfm1FbVuk+kzgmQ9dbYQLYDL Rfst7f1UU9rkQYogBJSYlJ9JJaovcGJn/Nt7FOILjh8sZdiO2Uet/mSEWyHdfYwuiX M+wPNnM0LD1ZIK/xY23JzcudzHfrwJIywhvkUoyqYfux0qRuSFbQr3mSHzBLnqy7Ww e6e3qc3R4YvvAZusGDEVlpcimimTh2apLtiwuQegGAzjeVQcd3Vl/ChcF43B2CFTaD 6NnqiyUgJInGM1PbdxOjemBLMOfx55/G2JF07t3YeBeMh8mLpspXsFhAtW13oUjJxA czQ2Rs0k0RXwQ== Date: Thu, 25 Aug 2022 04:28:56 +0300 From: Jarkko Sakkinen To: "Dhanraj, Vijay" Cc: "Chatre, Reinette" , Dave Hansen , "linux-sgx@vger.kernel.org" , Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , open list Subject: Re: [PATCH 2/2] selftests/sgx: Add SGX selftest augment_via_eaccept_long Message-ID: References: <20220815233900.11225-1-jarkko@kernel.org> <20220815233900.11225-2-jarkko@kernel.org> <6b304bb4-01cc-c88a-7299-19217a7a692b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2022 at 03:39:36PM +0000, Dhanraj, Vijay wrote: > > > > -----Original Message----- > > From: Jarkko Sakkinen > > Sent: Wednesday, August 17, 2022 7:39 AM > > To: Dhanraj, Vijay > > Cc: Chatre, Reinette ; Dave Hansen > > ; linux-sgx@vger.kernel.org; Shuah Khan > > ; open list:KERNEL SELFTEST FRAMEWORK > kselftest@vger.kernel.org>; open list > > Subject: Re: [PATCH 2/2] selftests/sgx: Add SGX selftest > > augment_via_eaccept_long > > > > On Wed, Aug 17, 2022 at 01:27:38AM +0000, Dhanraj, Vijay wrote: > > > I think changing it to "int i" will cause a buffer overflow with > > > edmm_size being 8GB. > > > > Hmm.. 'i' iterates segments. Amd I missing something? > > > > BR, Jarkko > > It is also used when iterating over pages to eaccept. This might cause an issue. > > for (i = 0; i < edmm_size; i += 4096) { > eaccept_op.epc_addr = (uint64_t)(addr + i); > > Regards, Vijay Ah got it, thanks. BR, Jarkko