Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <90296ab2-7531-8fd2-a541-ac6189f29988@quicinc.com>
Date:   Thu, 25 Aug 2022 10:18:44 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 1/5] soc: qcom: llcc: Rename reg_offset structs to
 reflect LLCC version
Content-Language: en-US
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        <bjorn.andersson@linaro.org>, <bp@alien8.de>, <mchehab@kernel.org>
CC:     <james.morse@arm.com>, <rric@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-edac@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_tsoni@quicinc.com>
References: <20220825043859.30066-1-manivannan.sadhasivam@linaro.org>
 <20220825043859.30066-2-manivannan.sadhasivam@linaro.org>
From:   Sai Prakash Ranjan <quic_saipraka@quicinc.com>
In-Reply-To: <20220825043859.30066-2-manivannan.sadhasivam@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/25/2022 10:08 AM, Manivannan Sadhasivam wrote:
> The register offsets used by the LLCC block retains its layout for multiple
> versions. For instance, starting from version v1.0.0 to v2.0.1 the offsets
> are same. And starting from v2.1.0, the offsets changed.
>
> But the current reg_offset naming convention is confusing. So to reflect
> this change correctly in driver, let's encode the start version from which
> the offsets got changed in reg_offset struct name. This will be
> llcc_v1_reg_offset for v1.0.0 and llcc_v2_1_reg_offset for v2.1.0.
> This will allow multiple SoCs to use the same reg_offset clearly.
>
> And in the future if the offsets got changed again, then that specific
> version could be encoded in the struct name.
>
> Suggested-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>   drivers/soc/qcom/llcc-qcom.c | 26 ++++++++++++++------------
>   1 file changed, 14 insertions(+), 12 deletions(-)

Reviewed-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com>


Thanks,
Sai