Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp322401rwe; Thu, 25 Aug 2022 00:26:08 -0700 (PDT) X-Google-Smtp-Source: AA6agR4VtFPMvgm8vAGYYaSRoXurLllDH/U3wFxBmWhOzVUq9t1IMhEipbEDQ+d7gT8ZYo9OCzxj X-Received: by 2002:a17:90b:514:b0:1f5:59b2:fceb with SMTP id r20-20020a17090b051400b001f559b2fcebmr3242713pjz.82.1661412368269; Thu, 25 Aug 2022 00:26:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661412368; cv=none; d=google.com; s=arc-20160816; b=zSXdzuViqkSNsv6hHJJJ1ewIefXNCuZMTNkcH2L/FQyjlNGEq2RzE6ArYzQfK/nhhs UUSevjm50NYLPY+6O0DK4H7P2Yd1UrPy8nQJJdmvfbPGnGzymn6A9xt73jj9yzamk8xU xFLy7aJe2zTnOOpEtwYnhNLgSYAZIpC57jQYe34RaYjDXeVyOpQp17UiMFwbXB7A7Clz zfDDyJkyu1aNoUBFJByk3PCia3P6WuT2lHejnOiyQ19EplCFyz9EDKwC/GR3j20sl/Bp EnQZCGEZGgKsIxli8N6prr523WGUp0srE8SIER7ldMIZjeLLKlHCaMe3W9KDli4+QLH3 j/WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=g0ShRhu8PCTy8HQapYgLH4SM3ceTYfJHm6+A9y4A03Y=; b=yVNgSKUrI5mJ3pCs+yiB2/3vrnOvdWlsZKYgJls0RWMVcC5CcMcRtACpc7JDbsiFNg qpFJuEyD8EIa2prVvj81zNI0IyAbIL3M6EO5PAW3FF0L9SgMDWkNPwXziBvXICgoKXLJ W/IdMVNh6vl+n4xBsLSjh7J06UdGAwItNLqAupIo+DZBmSPlT7zVdaqRWpu+UuBcno5O VTcUUIxR2TmwPOd3DoV8bpJVWwXi4HbvcTuQT+KjDZyo4HVorSJJdSnWUmeBtXIjiRSX 2grEfQcBYQql09J/ubGRSLRiITm7Z1xU5tuWt0rnWFFtqWHxETwlp9o49UuH9McZ4KUU 62uA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020a056a00151000b00525a80c57afsi12468281pfu.219.2022.08.25.00.25.57; Thu, 25 Aug 2022 00:26:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237108AbiHYHJ4 (ORCPT + 99 others); Thu, 25 Aug 2022 03:09:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235442AbiHYHJx (ORCPT ); Thu, 25 Aug 2022 03:09:53 -0400 X-Greylist: delayed 304 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 25 Aug 2022 00:09:50 PDT Received: from out30-42.freemail.mail.aliyun.com (unknown [115.124.30.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 689FA11455; Thu, 25 Aug 2022 00:09:50 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R381e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VNCEMA-_1661411080; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VNCEMA-_1661411080) by smtp.aliyun-inc.com; Thu, 25 Aug 2022 15:04:40 +0800 From: Yang Li To: tony@atomide.com Cc: lgirdwood@gmail.com, broonie@kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] regulator: drivers: Remove unnecessary print function dev_err() Date: Thu, 25 Aug 2022 15:04:38 +0800 Message-Id: <20220825070438.128093-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RDNS_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq_byname() already prints an error. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1986 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/regulator/tps65219-regulator.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c index 7ba2594e437c..ab16e6665625 100644 --- a/drivers/regulator/tps65219-regulator.c +++ b/drivers/regulator/tps65219-regulator.c @@ -363,11 +363,9 @@ static int tps65219_regulator_probe(struct platform_device *pdev) irq_type = &tps65219_regulator_irq_types[i]; irq = platform_get_irq_byname(pdev, irq_type->irq_name); - if (irq < 0) { - dev_err(tps->dev, "Failed to get IRQ %s: %d\n", - irq_type->irq_name, irq); + if (irq < 0) return -EINVAL; - } + irq_data[i].dev = tps->dev; irq_data[i].type = irq_type; -- 2.20.1.7.g153144c