Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp341387rwe; Thu, 25 Aug 2022 00:59:31 -0700 (PDT) X-Google-Smtp-Source: AA6agR5Mkia+Gf7StiyUKkhOMVVwE5Jmr5Hd4QDEXHMHoSPEFckvJipor4lfu8Sgnc7/5FTfycID X-Received: by 2002:a17:902:db06:b0:16f:16b7:69d0 with SMTP id m6-20020a170902db0600b0016f16b769d0mr2532794plx.145.1661414371361; Thu, 25 Aug 2022 00:59:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661414371; cv=none; d=google.com; s=arc-20160816; b=qa5dRFajl9M1cZM0f/BzbD8CyzSwi4tvRwhZ+PXZ7exEKsNLHpN/HcJ77JoZmm+fHK 2w7ZMyYfPj2uh2py5U9HpWTJqKb3dprAUc3i5IeBOMlObjT46tblvOK/o4KHK0HY47X3 8pmc3U/9uatwbVCwLiJrhcXWzVKK2Iou5SPklxG7WTl3IgkKWHKxnUavMynDMYD0ENip GSqPlmP6u8mZ164YNT6dWsLM4gw4S3VvMLOV88AOjSrdHhnAj0dhM0O/U2PV1gCXQ00M kehSjo1RflePr21lxzJt51wmejy4RAry73Q675jEeHiJFLUQ+2IZrxjav/yqdub9L4nY lgcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=x/Tz3VoY8os6cmOYc1dc3em/OjNfeifXSpuvoYYPzY0=; b=TBxAbt6RzmJ4x/ymbdujjEdavZnm0X39T+K36vuMWwgy4cfJ/7138lH/Cd9Tfou9Xw zXAqSZ92vzN6X4fxitPt11XqoXqhH8Vo8kA/wbQFbEoBM+NQHVWonRN9R5soQhxTN67R hRZWJBd6XeGqevF7ryOUr8QRzPj5WX6uhbtJ7F6aorgb6Meg1y+Q//ycFkQLA5nLaiPX UnmtypS+6K0bDLnKcxaOji0h5FR55wz3Z4HjiZ4dBCOngCmhTXGF4cIBDmDuk0hXhtHk 9Sg7hCGf8n3Jnxf/bd2ZdaMucILZpskXHbNHeFAuECwRyey7cQrbvV3bNW+z704WMI2Q 3nnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cfk9vnZT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u64-20020a637943000000b0041dd0c386ecsi19739048pgc.465.2022.08.25.00.59.19; Thu, 25 Aug 2022 00:59:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cfk9vnZT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236319AbiHYHeG (ORCPT + 99 others); Thu, 25 Aug 2022 03:34:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbiHYHeF (ORCPT ); Thu, 25 Aug 2022 03:34:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C8E1A2618; Thu, 25 Aug 2022 00:34:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E7B661A5E; Thu, 25 Aug 2022 07:34:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3F82C433D7; Thu, 25 Aug 2022 07:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661412843; bh=axugL1PnwsjK36BEwrge3Rb1zps3tluVnOEPQ4h7dJ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cfk9vnZTpBghZSOGo6gZGMaiiqaoteXixykg0tvqNtaHbkwLyunsup43EcVqlj8Mp xq3DtRTbmWcP0cOvOIq2PP6uqNKcA23DD5nLUBOsWBrZ/SDtmQDVa1MP+dlFOuhGc7 0f64Gb9z1i36kzWy1kzYl8V/19m3IocTu9k8zu18= Date: Thu, 25 Aug 2022 09:34:00 +0200 From: Greg Kroah-Hartman To: ira.weiny@intel.com Cc: Dan Williams , Bjorn Helgaas , Jonathan Cameron , Alison Schofield , Vishal Verma , Ben Widawsky , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH V2 1/2] PCI: Allow drivers to request exclusive config regions Message-ID: References: <20220824232450.723179-1-ira.weiny@intel.com> <20220824232450.723179-2-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220824232450.723179-2-ira.weiny@intel.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2022 at 04:24:49PM -0700, ira.weiny@intel.com wrote: > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -409,6 +409,7 @@ struct pci_dev { > */ > unsigned int irq; > struct resource resource[DEVICE_COUNT_RESOURCE]; /* I/O and memory regions + expansion ROMs */ > + struct resource config_resource; /* driver exclusive config ranges */ Naming is hard, but let's make this obvious what this resource is for as your comment states. How about: struct resource driver_exclusive_resource; Other than that, looks better to me, thanks for the update. greg k-h