Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of cadence.com designates
 64.207.220.244 as permitted sender) receiver=protection.outlook.com;
 client-ip=64.207.220.244; helo=wcmailrelayl01.cadence.com; pr=C
From:   Pawel Laszczak <pawell@cadence.com>
To:     <peter.chen@kernel.org>
CC:     <linux-usb@vger.kernel.org>, <gregkh@linuxfoundation.org>,
        <felipe.balbi@linux.intel.com>, <rogerq@kernel.org>,
        <a-govindraju@ti.com>, <linux-kernel@vger.kernel.org>,
        Pawel Laszczak <pawell@cadence.com>, <stable@vger.kernel.org>
Subject: [PATCH] usb: cdns3: fix issue with rearming ISO OUT endpoint
Date:   Thu, 25 Aug 2022 08:21:37 +0200
Message-ID: <20220825062137.5766-1-pawell@cadence.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-CrossPremisesHeadersFilteredBySendConnector: maileu5.global.cadence.com
X-OrganizationHeadersPreserved: maileu5.global.cadence.com
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fe5d0e28-1058-494b-4805-08da86621645
X-MS-TrafficTypeDiagnostic: SN6PR07MB5502:EE_
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: T1rvAo23GPgRdQIdUQtS1WdAOViDczyYEu16846rr7D4V7zDS44B71WagLIOOUEM0kNBQFnEp9RfI0DFq0crLdvbutfX8c8imeiGdRdktgkHm3/fFboLImY6AVIg0X9pFWbD6cTcPrdvbgDHgtOb+AQkhLv4p6yjxJPEZfAzGlZqSqepERxS33g4Zfi1jHp6nNHZX9pUIJwSa0Yt5K3qO4XfbVK8+nCer8H50qPqWyGcDP0wRsYc22cu5pHWKmUt2K9ye+jN/hsqSAKhjVBVpBaNAy3Gih1DT3kXIR4tlB5KhPRM/rlVpsJUzZN9eecvr73ifnRu/kFRSXQXQjovVfm3CZWkpDOoPA5sNnvoFFpzSCWpdPrA55J85HtyN5uBNEaku1MC4BvZGocb19TX4h4tnmoaUKgpjnrXJMmjOi+4XhMVWcNTIwpbQcv2VXxNfw6r1mKnH7hrh3tk9iX3inD/xIMyyX49RC7CGUqh+25nZfFhFcAgNtD8AoqhixWIFP0PeSiGFA1Es2uip3epQkpawkLz95mynq077HBZDiFujBSEqXETm5gou3WaLkM9nrBp3+RpzvnJ+XMXu/Id82fz1VhRX7ArW9Ptp9+C986jRto9YoR+ecfWeKesbse2yvK+HMhkKKZitszBQDf50RYcfByKQsh+Mma8CcJAUrPSwqKcV9bWRaQv29Cvfa7Ld+WZRnfNk+hnxC9JC6y3IEN1/sWYZygogkHFaP4I5GcRh8WyN3DpqK4fYCylPiZJRCgQCfN0qw1TQQpNZyc9Esh9Y1wthRa5cOzZ9Kx2QuYEA3RmSbvl97Gxr/dL6qxh
X-Forefront-Antispam-Report: CIP:64.207.220.244;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:wcmailrelayl01.cadence.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(346002)(136003)(36092001)(36840700001)(46966006)(40470700004)(81166007)(5660300002)(2616005)(1076003)(82740400003)(8936002)(426003)(356005)(47076005)(2906002)(6666004)(36756003)(36860700001)(82310400005)(478600001)(316002)(40460700003)(42186006)(6916009)(54906003)(26005)(70586007)(70206006)(41300700001)(4326008)(8676002)(83380400001)(40480700001)(186003)(336012)(86362001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 06:21:46.3340
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fe5d0e28-1058-494b-4805-08da86621645
X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9;Ip=[64.207.220.244];Helo=[wcmailrelayl01.cadence.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT116.eop-nam12.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5502
X-Proofpoint-ORIG-GUID: KdUzinQyXK2D2UdGOiQ2CQgvAzLLOcR9
X-Proofpoint-GUID: KdUzinQyXK2D2UdGOiQ2CQgvAzLLOcR9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-25_03,2022-08-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 bulkscore=0
 suspectscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 clxscore=1011
 mlxlogscore=346 impostorscore=0 spamscore=0 adultscore=0 malwarescore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208250021
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ISO OUT endpoint is enabled during queuing first usb request
in transfer ring and disabled when TRBERR is reported by controller.
After TRBERR and before next transfer added to TR driver must again
reenable endpoint but does not.
To solve this issue during processing TRBERR event driver must
set the flag EP_UPDATE_EP_TRBADDR in priv_ep->flags field.

Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
cc: <stable@vger.kernel.org>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
---
 drivers/usb/cdns3/cdns3-gadget.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
index 682ceba25765..fa8263951e63 100644
--- a/drivers/usb/cdns3/cdns3-gadget.c
+++ b/drivers/usb/cdns3/cdns3-gadget.c
@@ -1689,6 +1689,7 @@ static int cdns3_check_ep_interrupt_proceed(struct cdns3_endpoint *priv_ep)
 				ep_cfg &= ~EP_CFG_ENABLE;
 				writel(ep_cfg, &priv_dev->regs->ep_cfg);
 				priv_ep->flags &= ~EP_QUIRK_ISO_OUT_EN;
+				priv_ep->flags |= EP_UPDATE_EP_TRBADDR;
 			}
 			cdns3_transfer_completed(priv_dev, priv_ep);
 		} else if (!(priv_ep->flags & EP_STALLED) &&
-- 
2.25.1