Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 10:25:08 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     =?ISO-8859-15?Q?Jos=E9_Exp=F3sito?= <jose.exposito89@gmail.com>
cc:     benjamin.tissoires@redhat.com, spbnick@gmail.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] HID: uclogic: Add missing suffix for
 digitalizers
In-Reply-To: <20220815142615.17965-1-jose.exposito89@gmail.com>
Message-ID: <nycvar.YFH.7.76.2208251025020.19850@cbobk.fhfr.pm>
References: <20220815142615.17965-1-jose.exposito89@gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, 15 Aug 2022, José Expósito wrote:

> The Pen (0x02) application usage was changed to Digitalizer (0x01) in
> commit f7d8e387d9ae ("HID: uclogic: Switch to Digitizer usage for
> styluses"). However, a suffix was not selected for the new usage.
> 
> Handle the digitalizer application usage in uclogic_input_configured()
> and add the required suffix.
> 
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> 
> ---
> 
> Kindly resending this patch so it doesn't get lost after the merge
> window.
> ---
>  drivers/hid/hid-uclogic-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-uclogic-core.c b/drivers/hid/hid-uclogic-core.c
> index 47a17375c7fc..ff46604ef1d8 100644
> --- a/drivers/hid/hid-uclogic-core.c
> +++ b/drivers/hid/hid-uclogic-core.c
> @@ -153,6 +153,7 @@ static int uclogic_input_configured(struct hid_device *hdev,
>  			suffix = "Pad";
>  			break;
>  		case HID_DG_PEN:
> +		case HID_DG_DIGITIZER:
>  			suffix = "Pen";
>  			break;
>  		case HID_CP_CONSUMER_CONTROL:

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs