Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp374976rwe; Thu, 25 Aug 2022 01:47:22 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ti0O8zduUf3PVCBqrBNslqInHY/3LA+DQlzxwARPDhAJCQo66aJ3Ry/RfIXkxqKgxfSDX X-Received: by 2002:a17:903:48f:b0:172:bc2d:ae04 with SMTP id jj15-20020a170903048f00b00172bc2dae04mr2869288plb.34.1661417242157; Thu, 25 Aug 2022 01:47:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661417242; cv=none; d=google.com; s=arc-20160816; b=zZ7gtbUbwbu0ItFBCIXoEKxwRmQrneEs4bcSRTJRk4Njv3OW5Oevk1+KvdiqQBbcTy PG1MCfBJf39ghQ1sKaNYewYvQwL9IF0/eCCgKfB6leHAN91eqbDJ2iib8qPya6XcEzXj /0okIfykH9Ejqp0uAC/8p/8TRRlcMGjaSI6cZlNNh6EByeAvUH24akU89SE45PV81eET qIMZ6QPRItonHW9kPKEHYURf+0lT+bJN9xM+2ofRruK5HdEdIcnZvMn4frRg6Z+5swFj 1Fxw5V/a5WPgbF3pIGefxQQpdqY7hFXZE9nA/xKEcn9D0uLrkfcRmV4/UG9nYvwx73QU QeYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=OcjLuMaZ67d1MWtM678W6l6U0z7Sk/v4x4WaXyTs8QI=; b=RVcq6GDmdnFCQxLpB+WjWUIFyNc3wYMN1q/tAUxfl5f+ya+5sewkNzTXuMX/MT2YjU L+f8XKPSgsO2jLi7hnoJL3gjHp9EYqFDRAqSFlWKMouQ4o2a3biOJX2NE+pK+0T5Yoti GANXCF9g7SQRFZqht8gLda6zaBd+EpTq5znv6L8cU/5MiW9+BJS4lKXatiVurjF7oU1d Me7GJcUk4sNa0hdYaXymQB4/4I6Tyk38l2eVMs6TUY2tzDlv8f9CEfAtdqyW8Y4pe3lV XDpy9jQxsoi1WrgWmkh8Qvg6TqctjNKSqcbwE/C2/e2797KNJ28GhACr6lQCK7aY040S m04A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N61kPms6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q5-20020a056a00088500b005252be33906si2472758pfj.224.2022.08.25.01.47.11; Thu, 25 Aug 2022 01:47:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N61kPms6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237987AbiHYIWo (ORCPT + 99 others); Thu, 25 Aug 2022 04:22:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238045AbiHYIWl (ORCPT ); Thu, 25 Aug 2022 04:22:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE29CA5735; Thu, 25 Aug 2022 01:22:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2977B61AF6; Thu, 25 Aug 2022 08:22:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 799A9C433D7; Thu, 25 Aug 2022 08:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661415758; bh=uWhj5buhwHMeZlieGDkHSgadBEk4hW4Jr27pvQbKR6E=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=N61kPms6+ktr/YyZuKW+AfohFGERr330rt8HrFv02M+hv2lnFoOXYVGSmTNayDfnP qI3mV1qJUM02AATGlCNM0H22dhSOuYfOTjIaJ3uu32pSHgxlsermIEgvCEGS58QBld ilLDIoazBi3YsfMzUMJn1AOFxg9eRteTc1OUrl3qtzi678pbjcwHSQ0D0PljeFj95Q LUAGUv/fRUL9o4td82X/KaIJYFR6rNtYd0EYGoxar58KRsgIPugTB7F5gbHxX2qcgv BYZySJAY9MEdiOSQDgGc39W7v8hLyVsCUQzSkplZqIKzz9E4sSoiWX3TOTdr4Olf3G POlMnemo0wctw== Date: Thu, 25 Aug 2022 10:22:35 +0200 (CEST) From: Jiri Kosina To: Lee Jones cc: linux-kernel@vger.kernel.org, Benjamin Tissoires , linux-input@vger.kernel.org Subject: Re: [PATCH 1/1] HID: steam: Prevent NULL pointer dereference in steam_{recv,send}_report In-Reply-To: <20220708074009.621113-1-lee.jones@linaro.org> Message-ID: References: <20220708074009.621113-1-lee.jones@linaro.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Jul 2022, Lee Jones wrote: > It is possible for a malicious device to forgo submitting a Feature > Report. The HID Steam driver presently makes no prevision for this > and de-references the 'struct hid_report' pointer obtained from the > HID devices without first checking its validity. Let's change that. > > Cc: Jiri Kosina > Cc: Benjamin Tissoires > Cc: linux-input@vger.kernel.org > Fixes: c164d6abf3841 ("HID: add driver for Valve Steam Controller") > Signed-off-by: Lee Jones Sorry for the delay, I had some time off and things got stalled. Applied now, thank you. -- Jiri Kosina SUSE Labs