Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 10:58:15 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     cgel.zte@gmail.com
Cc:     mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        ran jianping <ran.jianping@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] EDAC,wq: remove unneeded flush_workqueue
Message-ID: <Ywc5p1lFSPsyY/cV@zn.tnic>
References: <20220424062127.3219542-1-ran.jianping@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220424062127.3219542-1-ran.jianping@zte.com.cn>
Precedence: bulk

On Sun, Apr 24, 2022 at 06:21:26AM +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
> 
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
> ---
>  drivers/edac/wq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c
> index d021d287eaec..ad3f516627c5 100644
> --- a/drivers/edac/wq.c
> +++ b/drivers/edac/wq.c
> @@ -37,7 +37,6 @@ int edac_workqueue_setup(void)
>  
>  void edac_workqueue_teardown(void)
>  {
> -	flush_workqueue(wq);
>  	destroy_workqueue(wq);
>  	wq = NULL;
>  }
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette