Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Jiaming Li <lijiamingsofine@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        lijiaming3 <lijiaming3@xiaomi.com>
Subject: RE: [PATCH] scsi: ufs: ufsfbo: Introduce File Based Optimization
 feature
Thread-Topic: [PATCH] scsi: ufs: ufsfbo: Introduce File Based Optimization
 feature
Thread-Index: AQHYt5Yd7MdiBMU/V0WwXjppS39zs62/UTVA
Date:   Thu, 25 Aug 2022 08:56:50 +0000
Message-ID: <DM6PR04MB657511C55B06E40552C03378FC729@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20220824084633.14428-1-lijiamingsofine@gmail.com>
In-Reply-To: <20220824084633.14428-1-lijiamingsofine@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Pbbn2YXWxerJh7wu8afuVQHlb0b9M66T7pmj09OeSJ79+2SuBXbXpLKd+cY3?=
 =?us-ascii?Q?pA2Xwv6hpo5clAoUc9+Vt5AOueUXpeFbeEiq2QyC/T8ML3yk4BniLnwy1NPo?=
 =?us-ascii?Q?u7cacc9HHXmxp/Yf5MU4r2YMhdfPYQHxbEZEUjwcHXQ7rgNqf/3jOsartZyi?=
 =?us-ascii?Q?Mtbv1S9gmHe9Zogoj7rg3fYEEIKg1MhNAKtJ/ZntO4n4gpaeb18hewczYjIw?=
 =?us-ascii?Q?hFMv5lbDq0NX9kScT3p7XBUk8FyQW8JW6JCyDSKiBgD/WFu5nAuuRca/LTsh?=
 =?us-ascii?Q?XJT8l9pyFomiPLlSbjCHE0NAuR21Oti1ESTHr2yRsiFyc7uJQ1r6S7aUkfeV?=
 =?us-ascii?Q?xQkj5e2/+3/hFOYlCFo1iZ7SS1iipMcQ7zEJbMAV6f6wMvouRGONRgg8H3kv?=
 =?us-ascii?Q?NzCkvtMfbK+dan6zZpVB84z+hSYNr1kxQgUMYadyTj8JOweDUUiLgHK2fova?=
 =?us-ascii?Q?LShvO2+7B7UQwHENoW0IEV4X3tOEfDU3NWVF2KFjb/q5Wu72vE2vmV2ndxte?=
 =?us-ascii?Q?gXRU1K5yb5mHt0KAYoeAyvJmG3ueVfVEcZ0LxLmbmK8RutThET1e2qdVCL45?=
 =?us-ascii?Q?xcyQL4ASpfGHFtEyuU+gHfhnWO5y5TUjw0wmuGkqNo9D3yXild26VPTLnRIZ?=
 =?us-ascii?Q?bQHr0ecBRbtMjrnGSJQaB0R+sdeMbieAdu6A23WAiEBAKvGWPvDrIBXnGPgk?=
 =?us-ascii?Q?GkH+ZEEEZCX6iVXUKo8A8xiBlrgEjoeRqbs1XH00Gb2EAwUFODcFGnsf4gdC?=
 =?us-ascii?Q?GYEGtTY6f3eFA2INz6+3Kqcu5XvbuDoE/aYyQJIhFavqkoGcOYff77ULwRJc?=
 =?us-ascii?Q?21Fe8MvNgRO89D/HOioqZNMZXPDof715d3uTq4HEZxVH/PJ8Bi/VGh2AZThn?=
 =?us-ascii?Q?ctzyapWI4D/4P3bzXCrhriVpdlCc8+Tzl7kaqhF0eW2YOLOgq8tW6uLqpYsv?=
 =?us-ascii?Q?dNPYx67IfKC/BCJTZv+ptvCXRp8x9tRwS+8NsbskBjlyjx6ReM5byoo69NpJ?=
 =?us-ascii?Q?9FoAXo29t3iyshRod3z+QrfQXcgg8oQyqmwXTaT5NGlykJQGDNIoPbCIkzWn?=
 =?us-ascii?Q?/MLi2LhE0SZGTn5ILsDggD6Z5kfAYmwFkSiSUTmr17Ve3OxRqEx+DeNCS6Sr?=
 =?us-ascii?Q?H6NGfNwUCup/LAlKTv9E+Xl3f8ok84rZ7YKQLrzheqX73TABn+sZvu62X8yq?=
 =?us-ascii?Q?tmhpr8SYtjfqid3s22ffXgpM1O3DfjdDAI1G1BeCWz57RY5QY4wOAHjpCZp9?=
 =?us-ascii?Q?00vQPwxBC96VGA7cujml9DsodmnACo395/lJnmdudJrMNp8BEvCPQXzbSrCL?=
 =?us-ascii?Q?afOFVRIKEQ6ZNgmbRa1zeIRuinA+RvO/n4aBZvOsZtHbTls4AtgdcZyZdzh1?=
 =?us-ascii?Q?dBNGoYCsdQY60TxmnmeOFSaxs7PwxKZY6l/circ79lPaiUH3zwaYjEE2heSl?=
 =?us-ascii?Q?d/Q6IjEPaKbhyATMUPQdzYiHLs9Fe6vncDhyZbWHOieoGEFcGpVd7VSk1HRN?=
 =?us-ascii?Q?EaivtX/we21xgpTHV8VtwEbJ3TCW/jgvLfPgbIsncctIcoxPV9ur2HNInQaJ?=
 =?us-ascii?Q?+fgJlzeiH642mm6NoEdNWlUSEz+WXzUrdmpEkuZc?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1161552-ef12-465b-05cb-08da8677bfc5
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2022 08:56:50.2312
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X5YMWj4SVmRovOxKgSUkeJENsIqL9tJL/s2+4zhjN431Q2ramD7WR8jW2RAjWxj9rzrjW8OKOIlyMJPsU8SAhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR04MB7452
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +
> +/* SYSFS DEFINE */
> +#define define_sysfs_ro(_name) __ATTR(_name, 0444,                     \
> +                                     ufsfbo_sysfs_show_##_name, NULL)
> +#define define_sysfs_wo(_name) __ATTR(_name, 0200,                     \
> +                                      NULL, ufsfbo_sysfs_store_##_name)
> +#define define_sysfs_rw(_name) __ATTR(_name, 0644,                     \
> +                                     ufsfbo_sysfs_show_##_name,        \
> +                                     ufsfbo_sysfs_store_##_name)
> +static struct ufsfbo_sysfs_entry ufsfbo_sysfs_entries[] =3D {
> +       define_sysfs_ro(fbo_rec_lrs),
> +       define_sysfs_ro(fbo_max_lrs),
> +       define_sysfs_ro(fbo_min_lrs),
> +       define_sysfs_ro(fbo_max_lrc),
> +       define_sysfs_ro(fbo_lra),
> +       define_sysfs_ro(fbo_prog_state),
> +       define_sysfs_ro(fbo_get_lr_frag_level),
> +       define_sysfs_ro(fbo_support),
> +       define_sysfs_ro(fbo_version),
> +       define_sysfs_wo(fbo_operation_control),
> +       define_sysfs_wo(fbo_send_lr_list),
> +       define_sysfs_rw(fbo_exe_threshold),
> +       define_sysfs_rw(fbo_wholefile_enable),
> +       /* debug */
> +       define_sysfs_rw(debug),
> +       /* Attribute (RAW) */
> +       define_sysfs_rw(block_suspend),
> +       define_sysfs_rw(auto_hibern8_enable),
> +       __ATTR_NULL
> +};
Lets stick to the _store / _show naming conventions -
people rely on that when they are grepping the code.
Also, you need to document the ABI.

Thanks,
Avri