Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 11:37:33 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc:     benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: vivaldi: convert to use dev_groups
In-Reply-To: <20220804113116.1117378-1-gregkh@linuxfoundation.org>
Message-ID: <nycvar.YFH.7.76.2208251137220.19850@cbobk.fhfr.pm>
References: <20220804113116.1117378-1-gregkh@linuxfoundation.org>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 4 Aug 2022, Greg Kroah-Hartman wrote:

> There is no need for a driver to individually add/create device groups,
> the driver core will do it automatically for you.  Convert the
> hid-vivaldi core driver to use the dev_groups pointer instead of
> manually calling the driver core to create the group and have it be
> cleaned up later on by the devm core.
> 
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: linux-input@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Applied, thanks Greg.

-- 
Jiri Kosina
SUSE Labs