Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220824140347.1842-1-henning.schild@siemens.com>
 <20220824140347.1842-2-henning.schild@siemens.com> <CAHp75Vf6agD-G1Ey1UgUvWnub4Q8-ysx3OMV14dR3ed5FRX=Vw@mail.gmail.com>
 <20220825113203.4e14f4d5@md1za8fc.ad001.siemens.net>
In-Reply-To: <20220825113203.4e14f4d5@md1za8fc.ad001.siemens.net>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 25 Aug 2022 12:56:48 +0300
Message-ID: <CAHp75Vd3VOx=+hzCgo6Wpz8Uwu9trxRiF_N=QYDBfidFvECyAw@mail.gmail.com>
Subject: Re: [PATCH v5 1/5] gpio-f7188x: Add GPIO support for Nuvoton NCT6116
To:     Henning Schild <henning.schild@siemens.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Pavel Machek <pavel@ucw.cz>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lee Jones <lee@kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Sheng-Yuan Huang <syhuang3@nuvoton.com>,
        Tasanakorn Phaipool <tasanakorn@gmail.com>,
        simon.guinot@sequanux.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 25, 2022 at 12:32 PM Henning Schild
<henning.schild@siemens.com> wrote:
> Am Wed, 24 Aug 2022 18:59:17 +0300
> schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:
> > On Wed, Aug 24, 2022 at 5:04 PM Henning Schild
> > <henning.schild@siemens.com> wrote:

...

> > > +#define gpio_dir_invert(type)  ((type) == nct6116d)
> > > +#define gpio_data_single(type) ((type) == nct6116d)
> >
> > What you are trying to do here is to put GPIO maintainers / heavy
> > contributors on a minefield (basically moving your job to their
> > shoulders). Please, provide a proper namespace and not gpio_ one. I'm
> > talking in my "GPIO heavy contributor" hat on.
>
> No i was trying to avoid having to touch those other 4 existing macros,
> touching lines that checkpatch.pl and you will pick on again. Adding
> the prefixes just to those new ones would be inconsistent and also not
> nice.

Do you have other prefixes in those files starting with gpio_?!
Now I see it. I'm not sure why this pops up only now.

> > With that fixed I can survive w/o pr_fmt() being in this patch. If you
> > are going to address this, you may add my tag in a new version.
>
> It is a bit unfortunate that you seem to be surprised where i said i
> was going to not address this.

Yes, because you are not a newbie and you know that the community
doesn't work on a "take it or leave" basis.

>  And once the new series comes insist on
> another round ... which involves testing and what not.

Which is your job as a developer.

> But hey, i will send a v6 with style refactoring patches and test it
> all over again.

Thanks!

> Thanks everyone for the review, i hope that next version will be
> acceptable and not open new discussion with the new patches coming.

-- 
With Best Regards,
Andy Shevchenko