Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 11:43:07 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Basavaraj Natikar <bnatikar@amd.com>
cc:     Akihiko Odaki <akihiko.odaki@gmail.com>,
        Basavaraj Natikar <basavaraj.natikar@amd.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v3] AMD_SFH: Add a DMI quirk entry for Chromebooks
In-Reply-To: <3bb043a4-987d-5896-29e1-21bb471da0e3@amd.com>
Message-ID: <nycvar.YFH.7.76.2208251142560.19850@cbobk.fhfr.pm>
References: <20220816102120.6131-1-akihiko.odaki@gmail.com> <3bb043a4-987d-5896-29e1-21bb471da0e3@amd.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 18 Aug 2022, Basavaraj Natikar wrote:

> On 8/16/2022 3:51 PM, Akihiko Odaki wrote:
> > Google Chromebooks use Chrome OS Embedded Controller Sensor Hub instead
> > of Sensor Hub Fusion and leaves MP2 uninitialized, which disables all
> > functionalities, even including the registers necessary for feature
> > detections.
> >
> > The behavior was observed with Lenovo ThinkPad C13 Yoga.
> >
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> > Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
> > ---
> >  drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> > index 4b90c86ee5f8..47774b9ab3de 100644
> > --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> > +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> > @@ -288,11 +288,29 @@ int amd_sfh_irq_init(struct amd_mp2_dev *privdata)
> >  	return 0;
> >  }
> >  
> > +static const struct dmi_system_id dmi_nodevs[] = {
> > +	{
> > +		/*
> > +		 * Google Chromebooks use Chrome OS Embedded Controller Sensor
> > +		 * Hub instead of Sensor Hub Fusion and leaves MP2
> > +		 * uninitialized, which disables all functionalities, even
> > +		 * including the registers necessary for feature detections.
> > +		 */
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Google"),
> > +		},
> > +	},
> > +	{ }
> > +};
> > +
> >  static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >  {
> >  	struct amd_mp2_dev *privdata;
> >  	int rc;
> >  
> > +	if (dmi_first_match(dmi_nodevs))
> > +		return -ENODEV;
> > +
> >  	privdata = devm_kzalloc(&pdev->dev, sizeof(*privdata), GFP_KERNEL);
> >  	if (!privdata)
> >  		return -ENOMEM;
> 
> Could you please prefix amd_sfh patches with 'HID: amd_sfh:'
> With that addressed,
> 
> Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

I have fixed that up and applied. Thanks,

-- 
Jiri Kosina
SUSE Labs