Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 11:34:12 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Arnd Bergmann <arnd@arndb.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH 5/4] ARM: footbridge: remove custom DMA address handling
Message-ID: <YwdQJDMExcm4n0vQ@shell.armlinux.org.uk>
References: <20220821055326.GA25950@lst.de>
 <20220825091752.3535657-1-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220825091752.3535657-1-arnd@kernel.org>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Thu, Aug 25, 2022 at 11:17:52AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Footbridge is the last Arm platform that has its own
> __virt_to_bus()/__bus_to_virt()/phys_to_dma()/dma_to_phys() abstraction,
> but this is just a simple offset now.
> 
> For ISA DMA (floppy etc), the offset is actually zero, so the special
> hack to subtract the bus offset can be removed from common code.

No, the offset is definitely not zero for ISA devices. ISA devices have
the same view of system memory as PCI devices, since ISA devices go
through a southbridge and on to the PCI bus. So their view of the system
is exactly the same as any other PCI device.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!