Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 12:11:54 +0200
From:   Lorenzo Pieralisi <lpieralisi@kernel.org>
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of/device: Fix up of_dma_configure_id() stub
Message-ID: <YwdK6seZfCTuDO4M@lpieralisi>
References: <20220824153256.1437483-1-thierry.reding@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220824153256.1437483-1-thierry.reding@gmail.com>
Precedence: bulk

On Wed, Aug 24, 2022 at 05:32:56PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Since the stub version of of_dma_configure_id() was added in commit
> a081bd4af4ce ("of/device: Add input id to of_dma_configure()"), it has
> not matched the signature of the full function, leading to build failure
> reports when code using this function is built on !OF configurations.
> 
> Fixes: a081bd4af4ce ("of/device: Add input id to of_dma_configure()")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  include/linux/of_device.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>

> diff --git a/include/linux/of_device.h b/include/linux/of_device.h
> index 1d7992a02e36..1a803e4335d3 100644
> --- a/include/linux/of_device.h
> +++ b/include/linux/of_device.h
> @@ -101,8 +101,9 @@ static inline struct device_node *of_cpu_device_node_get(int cpu)
>  }
>  
>  static inline int of_dma_configure_id(struct device *dev,
> -				   struct device_node *np,
> -				   bool force_dma)
> +				      struct device_node *np,
> +				      bool force_dma,
> +				      const u32 *id)
>  {
>  	return 0;
>  }
> -- 
> 2.37.2
>