Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 13:46:04 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Czerwacki, Eial" <eial.czerwacki@sap.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Arsh, Leonid" <leonid.arsh@sap.com>,
        "Twaig, Oren" <oren.twaig@sap.com>,
        SAP vSMP Linux Maintainer <linux.vsmp@sap.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Andra Paraschiv <andraprs@amazon.com>,
        Borislav Petkov <bp@suse.de>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Eric Biggers <ebiggers@google.com>, Fei Li <fei1.li@intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH v2] drivers/virt/vSMP: new driver
Message-ID: <20220825104604.GD2030@kadam>
References: <PAXPR02MB731058B69D178E026C578BB481729@PAXPR02MB7310.eurprd02.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PAXPR02MB731058B69D178E026C578BB481729@PAXPR02MB7310.eurprd02.prod.outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?62+oHthZsVTNb4QrOauOI2erVL1jOkjYVZrecKtLK/LizrKFDr+OfNkhxLTH?=
 =?us-ascii?Q?WxH4Q0zaCNIzT5ZTev6Lpck/Q8VuG7hmzih137l9euzPxkmvTaOR8sN/kTBx?=
 =?us-ascii?Q?MtsQ7Iu7E6XqiJlZNKVBoXrXqXszJgZS+/PUUYxUnClnwsgAj5bFBoUtUyQJ?=
 =?us-ascii?Q?j7yQ+2lm0fJob/7JF+wuAZJTZOX4s09lO3ljiKsGXso6gtjWIzGAs5o4UMjL?=
 =?us-ascii?Q?8zryR7j8Oa5T+8qFmpVtaFdYwHKc9Lxcl7fyw+fVjn/fwu9LQoTJX3cmik72?=
 =?us-ascii?Q?o0zhv5rvy0DtqDVbyVluL4QWqQ9pWwLqIiTodMNkpNGO7ur127Mn+38fZMBz?=
 =?us-ascii?Q?UWdVAwOKbWRylpxddT3XIa6tMMEtI3QdaQfnI4UeAyvVg2luQ07ZOk3ltt7f?=
 =?us-ascii?Q?wc45TGiTQUSj9o4g1NTpBfzMGevKzKlLlGNJ/4gDrgIsj1QOYWxfqzn+Xsnu?=
 =?us-ascii?Q?Mgvnnslw2ErFg8kgTEi/gAqXKA+mZiX1rcNUXAUUiSYrvF8omDwWzgc7/JF/?=
 =?us-ascii?Q?u4MJPxCrr9XFnYUUvQRNPkecYr+egVI7pwjXtdSoN6NiIHMQswxtF5QZc0TC?=
 =?us-ascii?Q?SiJpggahthuQ9xuUXjeqysCwdEiyEFh7PstI2kh6VqhUKNARMgZCuuE/c1Bv?=
 =?us-ascii?Q?4bZvO4MYpMFIp8MS2inYMWbGPqjEMln/KMqmsmt+M/9srlZzTflPxdeKoikM?=
 =?us-ascii?Q?Q4ngRfc5ydiJUxXuJVrgFJT8Yqg2zMsqcqdD4MS6JhW2Iw39+NlBAbm0G0GB?=
 =?us-ascii?Q?NIhUwmgvOozHskUgbKabJ9SI2nm6du7KNiZqES4rjYQzDyEpMJ7P2BgpXN0c?=
 =?us-ascii?Q?GZ1YugnGGmz/OL43H0pY3ST9Y0MipYF2g7Kaj0TFcq0PrmirlmyNFSI9DUkk?=
 =?us-ascii?Q?gafhwX3w6fMu4zdj1lbcndt/5XPRPw6ifQuNqKeYMqNSv2P1gU9Zzjiy4Edj?=
 =?us-ascii?Q?dbBlRzSefIkGff/xlS2GmfI/ZTqmu9znbT5zejSWiM4hh1R5/QHifOrZuPrx?=
 =?us-ascii?Q?OW8qeW3jQxEkOuOqe4UplgyyzMHgn9SQKI+tvzPzG0TW7s8vPTKeB02YOYBH?=
 =?us-ascii?Q?RG1g2cDwfCtOCPjmGzjW0GzE5JOR3MfxHMSDY91v7XXZ4+sJRdDOSmc6bCys?=
 =?us-ascii?Q?GLgq5Lv17wYo7fzlWnrCk75upNdBxb0iSPEI7G5pBoReBwaZS9ZCGwAfxJDG?=
 =?us-ascii?Q?s7UT8vtdcUTu8/q748hENYP4DMzpYf8yr39WSxxTJwHflhXqysc1EC326Dpd?=
 =?us-ascii?Q?Qob0ocRJTFWt1YCIAY6uk1KnayeTTlBh58idkoTyQzaQbOc/74LfoQWfrC79?=
 =?us-ascii?Q?Dri6Q/WRNLAVQbCN+/XEQzKVUz5Nb9+RFwtBCkXnbuNlF6ZOWdyQh7d1rr66?=
 =?us-ascii?Q?d6AbfeuVWFQskMGS2+X04ER1sgbkWDL4/Zkf/zZbSBGgClG2yBVV4u0ZmbhB?=
 =?us-ascii?Q?lKN43lKxQhItL8CeHPlrOqYutwidiXCr5OQPTqGHXV03GV81jgU0a3BsOpJl?=
 =?us-ascii?Q?hxoP2HAlJcrwIpt3dImv5UrTZqcV7nh6dDoraj4j3GeNSSDD9JXfncoPhL37?=
 =?us-ascii?Q?fqgjicJjIlLU/k5v3zSA/MpQuOOSqqGvnqfb3RmB?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e6c19ee-6314-4c9c-4d13-08da8687101e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 10:46:27.7662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8DAi9wb8qGWxOT4E7B+uK4C59TffwyMp7BEFRp0QlkvG6r6WEMp6OUyb/UkqG9XFUF5mMdQV8ThLU4OuSoKOYP890p+WhC6yr9Wy4w08eKY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6523
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-25_05,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0
 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208250042
X-Proofpoint-GUID: D0ewIpeQoIi83Ubx7vB1Sq0u8j6RssGE
X-Proofpoint-ORIG-GUID: D0ewIpeQoIi83Ubx7vB1Sq0u8j6RssGE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 25, 2022 at 06:24:02AM +0000, Czerwacki, Eial wrote:
> Introducing the vSMP guest driver which allows interaction with the
> vSMP control device when running a Linux OS atop of the vSMP hypervisor.
> vSMP is a resource aggregation hypervisor from SAP.
> 
> The driver comprises of api part which facilitates communication with
> the hypervisor and version which displays the hypervisor's version.
> 
> This patch s based on previous patches sent to the staging tree mailing
> lists
> 
> Signed-off-by: Eial Czerwacki <eial.czerwacki@sap.com>
> Acked-by: Leonid Arsh <leonid.arsh@sap.com>
> Acked-by: Oren Twaig <oren.twaig@sap.com>
> CC: SAP vSMP Linux Maintainer <linux.vsmp@sap.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Dan Carpenter <dan.carpenter@oracle.com>
> CC: Andra Paraschiv <andraprs@amazon.com>
> CC: Borislav Petkov <bp@suse.de>
> CC: Brijesh Singh <brijesh.singh@amd.com>
> CC: Eric Biggers <ebiggers@google.com>
> CC: Fei Li <fei1.li@intel.com>
> CC: Hans de Goede <hdegoede@redhat.com>
> CC: Jens Axboe <axboe@kernel.dk>
> CC: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> 
> v1 -> v2:
> 	- fix -0 var init in add_sysfs_entries (pointed out by Dan Carpenter)

Please don't resend patches the same day.  Always wait at least a day
but probably for a new driver wait 3 days.  There are going to be a lot
of comments on this.

My comment didn't even warrant a resend at all, it just something that
made me chuckle.  It will take a while to review this properly.

regards,
dan carpenter