Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220825090347.30555-1-junming@nfschina.com>
In-Reply-To: <20220825090347.30555-1-junming@nfschina.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 25 Aug 2022 13:22:41 +0200
Message-ID: <CAJZ5v0jVpCiwscgVQqS3yEwGaHUCPzR9pNDjt6qY6U4jJubt_A@mail.gmail.com>
Subject: Re: [PATCH] tools: Delete the initialization value
To:     shijm <junming@nfschina.com>
Cc:     Len Brown <lenb@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@acpica.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 25, 2022 at 11:04 AM shijm <junming@nfschina.com> wrote:
>
> From: Shi junming <junming@nfschina.com>
>
> From the perspective of commpier,delete the initialization value

I'm not sure what this means.

The initialization is unnecessary, because the variable in question is
always assigned a new value before reading it.  Is that what you
wanted to say?

> Signed-off-by: Shi junming <junming@nfschina.com>
> ---
>  tools/power/acpi/tools/pfrut/pfrut.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/acpi/tools/pfrut/pfrut.c b/tools/power/acpi/tools/pfrut/pfrut.c
> index d79c335594b2..52aa0351533c 100644
> --- a/tools/power/acpi/tools/pfrut/pfrut.c
> +++ b/tools/power/acpi/tools/pfrut/pfrut.c
> @@ -190,7 +190,7 @@ int main(int argc, char *argv[])
>         void *addr_map_capsule;
>         struct stat st;
>         char *log_buf;
> -       int ret = 0;
> +       int ret;
>
>         if (getuid() != 0) {
>                 printf("Please run the tool as root - Exiting.\n");
> --
> 2.18.2
>