Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 12:02:28 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Xiaolei Wang <xiaolei.wang@windriver.com>
Cc:     lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: pfuze100: Fix the global-out-of-bounds access
 in pfuze100_regulator_probe()
Message-ID: <YwdWxKywJXpkRC+s@sirena.org.uk>
References: <20220825071541.1228110-1-xiaolei.wang@windriver.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="N0zK4oVlzI+cCpvv"
Content-Disposition: inline
In-Reply-To: <20220825071541.1228110-1-xiaolei.wang@windriver.com>
Precedence: bulk


--N0zK4oVlzI+cCpvv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 25, 2022 at 03:15:41PM +0800, Xiaolei Wang wrote:

> This fixes the out of bounds access bug reported by KASAN.
>   BUG: KASAN: global-out-of-bounds in pfuze100_regulator_probe+0x380/0x8b8
>   Read of size 3968 at addr c3390640 by task swapper/0/1
>=20
>   CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.0.0-rc1-yocto-standard+ #2
>   Hardware name: Freescale i.MX6 SoloX (Device Tree)
>    unwind_backtrace from show_stack+0x18/0x1c
>    show_stack from dump_stack_lvl+0x68/0x90
>    dump_stack_lvl from print_report+0x58/0x4c8
>    print_report from kasan_report+0x7c/0x98
>    kasan_report from kasan_check_range+0x20/0x170
>    kasan_check_range from memcpy+0x28/0x68

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

--N0zK4oVlzI+cCpvv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMHVrEACgkQJNaLcl1U
h9AR+wf/WLvhTTUcHCmxgHXLdYWuM89scmK7+yWa+W+iv2Z5V+CVIehj50KIwGah
2oOJsMEr0QeAf2ATfPyOrnbhH05h7jXi+FaI4E3RsizhEC9bLytkUdvqtYLgiwdd
I+6Bh6gAOHVhut8DM6g9Cn6LwkLzug4Xzm+TccrdvZZ4OTs5cligWuAaP+i7je6l
Nshxx+f1cP6U0OxAAm6Bgro1E4HtqdlVJBmvMxTzzk/qXZ4+trRdsWhMT95PTRZ8
2Cyv/4EnEx22nLKJYqr2A8ZUHM+RKgAd41Qgqi0Bis4xDbVtvbYhu1Ovax5+KLu4
zLGkImT6cb8v4vVtIrwzbJ3a2E8vzQ==
=z+O8
-----END PGP SIGNATURE-----

--N0zK4oVlzI+cCpvv--