Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp623355rwe; Thu, 25 Aug 2022 06:33:37 -0700 (PDT) X-Google-Smtp-Source: AA6agR5+C8oE1Y7x0ILNwhjSakrf3pb58erdndiOFzxdxSdgGH85J9194dBcB2cHeK75eQWRitMj X-Received: by 2002:a17:907:843:b0:73a:5b0e:8352 with SMTP id ww3-20020a170907084300b0073a5b0e8352mr2564198ejb.438.1661434417530; Thu, 25 Aug 2022 06:33:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661434417; cv=none; d=google.com; s=arc-20160816; b=kaqFIRLvuUVU45ePgZgPU4+6t+aaP6n6qonXRDf4xbbQvT9v03rjiGumuqX5az2P9J 5hX0bHjqW5PAsKPurhuwidLKCx83MPKpOj4+nCcFrLamlSaLqdbMxDiZ96EImJsiRj/H rD9f0nLduqgxU3+M8AmAseDxcQzgrXF7Aqd0pAmF2ODgM0Q8wMoix9Y2o1yq5++ciFJg fE0cRVIBlFgbGrUKbtErIE+eQQ/VmNHsF1RAuWvNcbPfvRUMqOd5RgqgFi1HfUUwwHeb IS/nzIm7rAZuoXa0N1pZKjoN2ZWjI0lj29omdpv9pYjm4azLrh3Vce/RTXNjk0Wmz47t of7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=iDxQhmgdEBaaBcFPB6b962LhI50TUngnviNbrM+9DCg=; b=XEdBpfLgV9Y7ZWqJkEJNb3UuFRmwDzNUSKxMfD31u1eqnAsxQb44LWCyMpFJDPf/Bh ZMvQJdgez5gjdHOimS1augog0T1JX28f7I8BFE59k+p2MJLGqa/KJIiA+yKwp3QRGspd TlyN7VKn3Jvft/B9ngpv49WOjqggaTDMc+cEjej4pqAbtYkeIchyRO1rPj2S0W+h2KkI rUpGGBtIcbrh3yztSzOym9EIClynRESR8nitrEZgzdmi8x/ncgJ/gh7AU1BXv6O0/47z eghm7RuhInrX8V6M48U3WKn7d7q4jBobvhX4Pln8heC2Wx1RSTPuFrSpLOO0Qv5k13Ig y8cQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a056402430d00b00446ba684e2asi6653298edc.367.2022.08.25.06.33.11; Thu, 25 Aug 2022 06:33:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242353AbiHYNMy convert rfc822-to-8bit (ORCPT + 99 others); Thu, 25 Aug 2022 09:12:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242343AbiHYNMx (ORCPT ); Thu, 25 Aug 2022 09:12:53 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A63FAF4A2 for ; Thu, 25 Aug 2022 06:12:47 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-55-HXv8MwvfNtijA9b15ilGWA-1; Thu, 25 Aug 2022 14:12:44 +0100 X-MC-Unique: HXv8MwvfNtijA9b15ilGWA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Thu, 25 Aug 2022 14:12:42 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.040; Thu, 25 Aug 2022 14:12:42 +0100 From: David Laight To: 'Peter Zijlstra' , Segher Boessenkool CC: Borislav Petkov , X86 ML , Michael Matz , "linux-toolchains@vger.kernel.org" , LKML , "Josh Poimboeuf" Subject: RE: [PATCH] x86/sev: Mark snp_abort() noreturn Thread-Topic: [PATCH] x86/sev: Mark snp_abort() noreturn Thread-Index: AQHYuE2/3wA7Q5vXrk6DdQVA60XyvK2/lqOw Date: Thu, 25 Aug 2022 13:12:42 +0000 Message-ID: References: <20220824152420.20547-1-bp@alien8.de> <20220824172929.GA25951@gate.crashing.org> <20220824224144.GC25951@gate.crashing.org> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... > Objtool follows control flow. As you said above, noreturn functions > behave differently and code-gen after a call to a noreturn function > stops. Thinks.... How near is objtool to outputting a list of functions and the stack offset at which they call something else? With the 'magic numbers' to track indirect jumps that is very nearly enough information to do full static stack depth checking. Recursive calls are a problem - but they ought to be banned in kernel anyway. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)