Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp627253rwe; Thu, 25 Aug 2022 06:37:26 -0700 (PDT) X-Google-Smtp-Source: AA6agR6hiNul/DZT0vWipg/iWqL8sbCgqX0nda+1FdHeb5XibI2dDfl4ngYQjtFj4vqRuwOUAcUY X-Received: by 2002:a05:6402:43cf:b0:446:b290:ea84 with SMTP id p15-20020a05640243cf00b00446b290ea84mr3254252edc.119.1661434646725; Thu, 25 Aug 2022 06:37:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661434646; cv=none; d=google.com; s=arc-20160816; b=GxIBI8R4V33VnS7CauTrC87ODQOmKgQhs5ORNp1+u1TM3h2efDBC1UiAw3RxgbDP+N Uwf9oEFsv225igrp/gmCVecwCEHEuJGQ0I23+yzmhOzon+FxbZqBNlw4uAKr/s8jKEMo OoRELG2Uk714IruCCiDF5+LHzFFqt5u608JC7HqE//rMe3LeLsUWA09wqOn9k4IuYS3X nzVLdhmuZPdXvzyXAXvvjGZ+XNydXt5LjQga6veMVkvHXLQYf8U5QKcyZcRyDHF1mYRq YKr6X4i/0tEiyufYtdqD60UxW8xe2lsIa5wlLncpKYl7Ow5SkXG6MiS7HYt3pR6ORvzq VGWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=5uGW1QYvtlG/bdEy5L5ZLgqQOoPkfR3adZmBDiRiDAY=; b=Ozxc6E/iHJd7hLhbvvwLaPccxZe+7WY5alNMZ87UnCZa2Qaf2A3ukx1CW6qMyppfOZ t3o2NM3Uh560q9FYQkAmtkwib5men7DhMnbUqWvBDu+B7buLI41CJkgBUUUvLEhT+rLn x0+/Mb1VQjrQpXAL4dU8kHnXtfgUAmXnqnXibD3fwA/Wzftc/O05/2/piFdbOjkoF06f PGS7KyKuyh6mMFOjbxsafWcy+wrYsvVyytwgBlYA8cUZYBXMvhNf9NF//FEX/m+sD+qI QMQPQ2lvNlC5PuzpP+XeqXX35wMI3W0WK2f1c4TxqLCGr+oRrlN7fvp/s0Q916VDRgYA JHXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a056402430d00b00446ba684e2asi6653298edc.367.2022.08.25.06.37.00; Thu, 25 Aug 2022 06:37:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242258AbiHYNDI (ORCPT + 99 others); Thu, 25 Aug 2022 09:03:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242150AbiHYNCr (ORCPT ); Thu, 25 Aug 2022 09:02:47 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD7F08A1D9 for ; Thu, 25 Aug 2022 06:02:40 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRCUz-0007zZ-9g; Thu, 25 Aug 2022 15:02:17 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oRCUw-001uGX-BU; Thu, 25 Aug 2022 15:02:14 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oRCUv-00FeUi-3j; Thu, 25 Aug 2022 15:02:13 +0200 From: Oleksij Rempel To: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, David Jander , Luka Perkov , Robert Marko Subject: [PATCH net-next v2 5/7] net: mdiobus: search for PSE nodes by parsing PHY nodes. Date: Thu, 25 Aug 2022 15:02:09 +0200 Message-Id: <20220825130211.3730461-6-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220825130211.3730461-1-o.rempel@pengutronix.de> References: <20220825130211.3730461-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some PHYs can be linked with PSE (Power Sourcing Equipment), so search for related nodes and attach it to the phydev. Signed-off-by: Oleksij Rempel --- drivers/net/mdio/fwnode_mdio.c | 37 ++++++++++++++++++++++++++++++++-- drivers/net/phy/phy_device.c | 2 ++ include/linux/phy.h | 2 ++ 3 files changed, 39 insertions(+), 2 deletions(-) diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c index e78ad55c0e091..1e775c449f5db 100644 --- a/drivers/net/mdio/fwnode_mdio.c +++ b/drivers/net/mdio/fwnode_mdio.c @@ -10,10 +10,31 @@ #include #include #include +#include MODULE_AUTHOR("Calvin Johnson "); MODULE_LICENSE("GPL"); +static struct pse_control * +fwnode_find_pse_control(struct fwnode_handle *fwnode) +{ + struct pse_control *psec; + struct device_node *np; + + if (is_acpi_node(fwnode)) + return NULL; + + np = to_of_node(fwnode); + if (!np) + return NULL; + + psec = of_pse_control_get(np); + if (IS_ERR_OR_NULL(psec)) + return NULL; + + return psec; +} + static struct mii_timestamper * fwnode_find_mii_timestamper(struct fwnode_handle *fwnode) { @@ -89,14 +110,21 @@ int fwnode_mdiobus_register_phy(struct mii_bus *bus, struct fwnode_handle *child, u32 addr) { struct mii_timestamper *mii_ts = NULL; + struct pse_control *psec = NULL; struct phy_device *phy; bool is_c45 = false; u32 phy_id; int rc; + psec = fwnode_find_pse_control(child); + if (IS_ERR(psec)) + return PTR_ERR(psec); + mii_ts = fwnode_find_mii_timestamper(child); - if (IS_ERR(mii_ts)) - return PTR_ERR(mii_ts); + if (IS_ERR(mii_ts)) { + rc = PTR_ERR(mii_ts); + goto clean_pse; + } rc = fwnode_property_match_string(child, "compatible", "ethernet-phy-ieee802.3-c45"); @@ -132,18 +160,23 @@ int fwnode_mdiobus_register_phy(struct mii_bus *bus, goto clean_phy; } + phy->psec = psec; + /* phy->mii_ts may already be defined by the PHY driver. A * mii_timestamper probed via the device tree will still have * precedence. */ if (mii_ts) phy->mii_ts = mii_ts; + return 0; clean_phy: phy_device_free(phy); clean_mii_ts: unregister_mii_timestamper(mii_ts); +clean_pse: + pse_control_put(psec); return rc; } diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 0c6efd7926907..221bc872ee2fb 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -988,6 +989,7 @@ EXPORT_SYMBOL(phy_device_register); */ void phy_device_remove(struct phy_device *phydev) { + pse_control_put(phydev->psec); unregister_mii_timestamper(phydev->mii_ts); device_del(&phydev->mdio.dev); diff --git a/include/linux/phy.h b/include/linux/phy.h index 87638c55d8442..0c91870b82582 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -588,6 +588,7 @@ struct macsec_ops; * @master_slave_get: Current master/slave advertisement * @master_slave_state: Current master/slave configuration * @mii_ts: Pointer to time stamper callbacks + * @psec: Pointer to Power Sourcing Equipment control struct * @lock: Mutex for serialization access to PHY * @state_queue: Work queue for state machine * @shared: Pointer to private data shared by phys in one package @@ -701,6 +702,7 @@ struct phy_device { struct phylink *phylink; struct net_device *attached_dev; struct mii_timestamper *mii_ts; + struct pse_control *psec; u8 mdix; u8 mdix_ctrl; -- 2.30.2