Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <109c37f0-8b1a-40d0-7b86-dde80fb77081@linaro.org>
Date:   Thu, 25 Aug 2022 15:35:07 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH] dt-bindings: gpio: mpfs-gpio: allow parsing of hog child
 nodes.
Content-Language: en-US
To:     Conor.Dooley@microchip.com, mail@conchuod.ie,
        linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org
Cc:     linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220820204130.1380270-1-mail@conchuod.ie>
 <0ecf1664-03a2-71ac-b967-6905b96c7ce0@linaro.org>
 <e94c1de8-e5e3-2325-38f9-1606c9369aef@microchip.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <e94c1de8-e5e3-2325-38f9-1606c9369aef@microchip.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/08/2022 15:30, Conor.Dooley@microchip.com wrote:
> On 25/08/2022 13:10, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 20/08/2022 23:41, Conor Dooley wrote:
>>> From: Conor Dooley <conor.dooley@microchip.com>
>>>
>>> The SD card and eMMC on PolarFire SoC based dev boards are sometimes
>>> statically muxed using a GPIO. To facilitate this, enable gpio-hog
>>> child node properties.
>>>
>>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>>> ---
>>>   .../bindings/gpio/microchip,mpfs-gpio.yaml     | 18 ++++++++++++++++++
>>>   1 file changed, 18 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
>>> index 110651eafa70..6704a7a52cd0 100644
>>> --- a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
>>> +++ b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
>>> @@ -44,6 +44,24 @@ properties:
>>>
>>>     gpio-controller: true
>>>
>>> +patternProperties:
>>> +  "^.+-hog(?:-[0-9]+)?$":
>>
>> What is this pattern about: "(?:" ?
> 
> Me being a pedant I suppose. "()" is a capture while "(?:)" is a match.
> However, it does seem like json-schema suggests using "()":
> https://json-schema.org/understanding-json-schema/reference/regular_expressions.html
> 
> I don't mind & neither does the schema checker.

Use what existing sources are doing, so "^.+-hog(-[0-9]+)?$"

Best regards,
Krzysztof