Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 17:46:42 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Alex Deucher <alexander.deucher@amd.com>
Subject: drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:311
 dc_dmub_srv_p_state_delegate() warn: variable dereferenced before check 'dc'
 (see line 309)
Message-ID: <202208252240.i49DVUes-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TatnYZ2FY1dOxZsMbvCUgUPiZC1GBWMaRxICATsCMQj2WoXfmpCEw5K3K213?=
 =?us-ascii?Q?EODjN3LvADHqqfx2OsgqOvC4/KrOuGA9CxTzcSnPG2RYexY0apUVzTwlkDc9?=
 =?us-ascii?Q?tk06HiwnoIarS+uOCyc02FH7ZBenrWAQCloSitA7mh9nDby6rRYuUmLVqep6?=
 =?us-ascii?Q?I40+3y3p5CqXyFyLi7kHbi3q5K5ZOylh71c39uWZ0sXkFEt/rXtSaiQkvgki?=
 =?us-ascii?Q?YgqnafLR1VDeFYFpRjO5R7f9WzVsisOUIDBQKj5BdmgaEsuj12dISIhk9n/i?=
 =?us-ascii?Q?BPrKTHD+FPkm2CnoM/EeKobGmqc7zu3pfQ04RDPHkfX/2Ovo0UUosK3YZMU6?=
 =?us-ascii?Q?LqN8V7QjZShLVpuL0mjNiPSzSU2UCSjfXFfWwPaSDoFZzKCQCCB54Y1XQMFD?=
 =?us-ascii?Q?UaS+SoZGmIyXBe03V4bfT8NUyv0XhD+b1bAwS76EHTR7lT37QR975J6nZxZn?=
 =?us-ascii?Q?WgCeOrG8wFw6hq+eZ+2ylV8tP509t+d1OY4XRQcUMRG/RflDyM8l2Qvxgg7Z?=
 =?us-ascii?Q?5niKz0wT3NM151ThcWMIBCsg80+ifrVhm79CvhPjEzrrKc0LKYuMAcOexvLA?=
 =?us-ascii?Q?rrxuYjuncchJh0uw/D1h9Qz5KZB5XwX2Bajebn/POLICYvIXftcw5UKaBJf5?=
 =?us-ascii?Q?ZH0O5FnXuTqObja71PQu6ogpUa5Rffh4I0wOsAaH87UqKiZFtr5dX6lxkgRJ?=
 =?us-ascii?Q?Es9DrxC/QShH/h4U8mfOHQxqLb+re+Ehi6TaT3WJFuKYAmTPDzgGWvG5skrz?=
 =?us-ascii?Q?1L38buwaUdbcgH1ayQ7YIPY/mBAodQN924PaY36zKuPw8o6IwXI+LCy8uiZf?=
 =?us-ascii?Q?nCU6b96M7h9XaGXQ3n0XkV8r720sb64FcqDQg+KbczpLnOVGq2qVHDdfvwQN?=
 =?us-ascii?Q?5P97phFDqFSYBjOyvzIHZwKnxdmk6PAAGXmJKRrDfh+/A3JXjCg4CitnX90P?=
 =?us-ascii?Q?m+pTJDA5/ktSq/kgeqUVQhSgnlkbA1OFwG5bqNdDwLgsEoaURNnLdE43+N/x?=
 =?us-ascii?Q?OWvegahSZjIukHrrhRpbfX9NPtpWTrdlGjpP9ly3neWkqlK9qiEagGekW02N?=
 =?us-ascii?Q?cL0dtArI3/+UQMEaVIsLRpOxan7kNucOiCI/afBf5NV02oz3qhP1pezLf1wl?=
 =?us-ascii?Q?XfvcBzfBQzhyb1ENtpVzRSMzRwD6PRQkD4sUIU2w2+Myqb71DRXyg1XDJYjM?=
 =?us-ascii?Q?fNcGOAQDUqn2nMg89RxqEn1LNFv8h5MXqNiedzmRenuHaVN0Qzg/2gCVfWAq?=
 =?us-ascii?Q?qwFSpcKCZ32mGB6JAyCgtzzNxj4bf2o/8m6iwxVudbHVdXAxX4jz/E6LPhOU?=
 =?us-ascii?Q?NIGoQ6EoRFj8QkzvsfR6uV86RQOkGiBUsdiVuZwi8RamAM9S6oaLFXeIL7pu?=
 =?us-ascii?Q?IVPO7BGSM031TabKOQ5LLDSaSY96vOagKt9IDDeMqCWXLPmn+hP+pGA5l7V7?=
 =?us-ascii?Q?m6kNyMs7c1cayMh33w04mWPgfN00eZ/vONPjW7pYuxd8Wo9m2bD+CFBX4Ykv?=
 =?us-ascii?Q?6fPl14HpLz7U3jNaa52wHtbrQwnnwjdJoTKZwSJOGj6WBQ5myIwMzIJCFrfC?=
 =?us-ascii?Q?lPZIYkUNXtmc7PlcFzKuzVAV303hQjnOtKKpVPKMXOYJ7zzY66YP8jyFDDk7?=
 =?us-ascii?Q?0w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31445962-ecb2-4b21-a1f6-08da86a8abca
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 14:47:02.5845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vfo53eF+yUsoD5ODbW+Ib43jomuWfu1BSqANBqlLV46dBaZIP3z9yi2m5stCrILuAbJ8IRwzxx716IQE6WF4v3j5dUckkNi+9aXTmWdXfk8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3439
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-25_06,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208250055
X-Proofpoint-ORIG-GUID: bNh7q226iwfdKSBXF-SuQ2CJfg9VEkHz
X-Proofpoint-GUID: bNh7q226iwfdKSBXF-SuQ2CJfg9VEkHz
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c40e8341e3b3bb27e3a65b06b5b454626234c4f0
commit: 00fa7f031dd4b885175da390e24cb02f6a45977e drm/amd/display: Add basic infrastructure for enabling FAMS
config: microblaze-randconfig-m041-20220824 (https://download.01.org/0day-ci/archive/20220825/202208252240.i49DVUes-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:311 dc_dmub_srv_p_state_delegate() warn: variable dereferenced before check 'dc' (see line 309)

vim +/dc +311 drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c

00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  303  bool dc_dmub_srv_p_state_delegate(struct dc *dc, bool should_manage_pstate, struct dc_state *context)
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  304  {
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  305  	union dmub_rb_cmd cmd = { 0 };
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  306  	struct dmub_cmd_fw_assisted_mclk_switch_config *config_data = &cmd.fw_assisted_mclk_switch.config_data;
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  307  	int i = 0;
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  308  	int ramp_up_num_steps = 1; // TODO: Ramp is currently disabled. Reenable it.
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16 @309  	uint8_t visual_confirm_enabled = dc->debug.visual_confirm == VISUAL_CONFIRM_FAMS;
                                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^
Dereference

00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  310  
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16 @311  	if (dc == NULL)
                                                            ^^^^^^^^^^
Too late

00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  312  		return false;
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  313  
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  314  	// Format command.
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  315  	cmd.fw_assisted_mclk_switch.header.type = DMUB_CMD__FW_ASSISTED_MCLK_SWITCH;
00fa7f031dd4b88 Rodrigo Siqueira 2022-06-16  316  	cmd.fw_assisted_mclk_switch.header.sub_type = DMUB_CMD__FAMS_SETUP_FW_CTRL;

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp