Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 09:56:15 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-mm <linux-mm@kvack.org>,
        open list <linux-kernel@vger.kernel.org>,
        regressions@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        David Hildenbrand <david@redhat.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        James Houghton <jthoughton@google.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Michal Hocko <mhocko@suse.com>,
        Mina Almasry <almasrymina@google.com>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        Pasha Tatashin <pasha.tatashin@soleen.com>,
        Peter Xu <peterx@redhat.com>,
        Prakash Sangappa <prakash.sangappa@oracle.com>
Subject: Re: [next] x86: fs/hugetlbfs/inode.c:673:16: error: variable
 'm_index' is uninitialized when used here [-Werror,-Wuninitialized]
Message-ID: <Ywepr7C2X20ZvLdn@monkey>
References: <CA+G9fYsHVdu0toduQqk6vsR8Z8mOVzZ9-_p3O5fjQ5mOpSxsDA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+G9fYsHVdu0toduQqk6vsR8Z8mOVzZ9-_p3O5fjQ5mOpSxsDA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0ndykdbC21JzfFQMnke8l6DVqTpO8GyxPX6eCX07Rjwik4+H6nVg39w4FJ3V?=
 =?us-ascii?Q?3XjSXrR/3DupZKebb1HpQ9WEyusqZjZWcMd2G5XxwD29suiFnT0CYsMpwKXb?=
 =?us-ascii?Q?6BnCPLp/TpIyzU58Ad9q6k40eitTv2759mGThjfT0SdUPJxt9yqUXpU38EI4?=
 =?us-ascii?Q?xsYMVIGc+0IIcHMwkVod/0jg5TtyWpHZU07QVFe/20+OUnIMalHXUjnPPcUN?=
 =?us-ascii?Q?PIEaMGQZU3TzJkPJ+AP0i8iFxyl1+MYeBD5OEDxH2vtwt57CHsZuBWI/u/KU?=
 =?us-ascii?Q?3sHLwmHRsx6Q4cPj+OgooafYTFj/IG5x54xqBWI7W5uZHu/GsncgRXrm4pCq?=
 =?us-ascii?Q?nscn7KnmnPv9hvdbUvCgCSIYAhDQG+6m2sIsYzZyYVe1Rd+3x2IIGFBFQTq0?=
 =?us-ascii?Q?BT9BCd5byC/pxnE1o6gL1YIo0Ge109bhqKnn3H9SUoKX/cKt6Df2jZQ/e0xX?=
 =?us-ascii?Q?tU0gU5KNMLd56hUYdPHqHNlp0nW1ygE0FbQc4aTHU2u+4NX4cvc61G2Nht/N?=
 =?us-ascii?Q?lXUb2IENWiIo+ucOmQZoIDujdZV7eEra6qVEYDAg2VFaBbtkZ/LHFcewBphM?=
 =?us-ascii?Q?Otgps/hGi6GBe37XdAkqX4o0Vpw2PYxC0leFTSC9nof5hQrObwz/N9esUZ50?=
 =?us-ascii?Q?+Ej4NJVt01e0EoCBv3ao1N2Dc3s+GMrG/5pOuHjtG6iiyF2bWg3w9MRSacVE?=
 =?us-ascii?Q?M7BKPTircjhuEwz0aYt179AuqYfJvr37aVvxEbXP03q/37EHID+cIXFIlz1u?=
 =?us-ascii?Q?t9b8DyB/kMQ1mYIpfi8fYsuuCTVFwAAOJdhF5GFetNGoPm3PTSpypLN8L0VY?=
 =?us-ascii?Q?g4iyUAcSlI910iam7QV6KlMXaRgE/TW2kUjYOSWHCglXQFZpsJOstyMLQAFV?=
 =?us-ascii?Q?i3qSaZqjwgzbk7N+vJxg8XQO2ODgRqULVUkPM4+o/K7MrN4kVvrkdv2FaxUR?=
 =?us-ascii?Q?2WK/4SgBcBT2jHoi/7RMNAUWZUVnqYCa26gYtuAWw7H0zye/GD2/MaTIx4oE?=
 =?us-ascii?Q?8fucZldxgtuToxHcVg/Cw552jznXcAzeJBKGwca0TRPvoPJ5wAmVHoLUIY/U?=
 =?us-ascii?Q?ksqCkqATZp2ap0l9slQT4quYhyRdTkLvZDcPhe2/2PpXoIY4q++EmfzoTdl3?=
 =?us-ascii?Q?MdTbn6Yhi5+DcNBb3GCavnxTcPmH+iLsobYSrB0ij6ghDejrqfCIpfolT/iD?=
 =?us-ascii?Q?33t8jpEdA+Al5CxwotLabuMK+JJ4Dpb7MmNzUECaDIoIeCWLS+/R2jDmxm7E?=
 =?us-ascii?Q?U+dp4fDywU+CxeScBUX7A0hHo0fKmAwC2gRqq2WPQfdAzjHddmVpiV1NVWqj?=
 =?us-ascii?Q?B9HtkE4ZfQ/X6qTHtrxeijWlxXgMcyrEjdAFV/K46zmZYYfnkSQaSHV/PXZW?=
 =?us-ascii?Q?JqYZFTJ6YrVLHpmyc+M1PtGZ/Y542y9peb4fy1+LiRVOHr+Xo09PY1a2Z69l?=
 =?us-ascii?Q?OZpDquHUk9zj32FFj9UM7feww7g5Flg7QTGFHVFJv03ls9UTO9886Lg1aalh?=
 =?us-ascii?Q?LBfWyZZloCHeOo7Pj0gmM43nPdYsEE4HMFsNzm74wHxyQ5SumswmA9iGZUCJ?=
 =?us-ascii?Q?HxC//5jVdPwm9QMglK8k1WGvlkiZj0mNnJaTiJwF+i/J4rWqjuusCIoj2Dcb?=
 =?us-ascii?Q?XA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: daf89b94-e787-44cc-b929-08da86babaa5
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 16:56:19.2488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vXjfKcnW7NXREHijLa5PpTvFsY0MGwFWZkoz+CzPio07yzA39DG1XA30oKXXotzn02/kRkHOpwabOoooYGSEbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR10MB6425
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-25_08,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208250064
X-Proofpoint-ORIG-GUID: AiePTlAF3zJx_NPoeI21V2YKI4pZnOQa
X-Proofpoint-GUID: AiePTlAF3zJx_NPoeI21V2YKI4pZnOQa
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/25/22 16:13, Naresh Kamboju wrote:
> The x86_64 and i386 clang builds failed due to these warnings / errors
> on Linux next-20220825.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> fs/hugetlbfs/inode.c:673:16: error: variable 'm_index' is
> uninitialized when used here [-Werror,-Wuninitialized]
>                                                 m_start, m_index, truncate_op);
>                                                          ^~~~~~~
> fs/hugetlbfs/inode.c:651:26: note: initialize the variable 'm_index'

Thanks!  That really should be 'index' and not 'm_index'.  The variable
m_index was used in a previous version of the code and should have been
deleted.  Depending on the uninitialized value of m_index, this could
cause long delays as the called routine checks the range m_start to m_index.

Andrew, how would you like to address in your tree?  The following patch
can be applied on top of the original (next commit fcc0d3d00d74 "hugetlb:
handle truncate racing with page faults").  Or, I could squash and
resend the original, or resend the entire series.


From 99aae359c3a744e6718045d2f24b55c84bed4d56 Mon Sep 17 00:00:00 2001
From: Mike Kravetz <mike.kravetz@oracle.com>
Date: Thu, 25 Aug 2022 09:49:08 -0700
Subject: [PATCH] hugetlb: fix/remove uninitialized variable in
 remove_inode_hugepages

Code introduced for the routine remove_inode_hugepages by patch "hugetlb:
handle truncate racing with page faults", incorrectly uses a variable
m_index.  This is a remnant from a previous version of the code when
under development.  Use the correct variable 'index' and remove
'm_index' from the routine.

Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
---
 fs/hugetlbfs/inode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 52d9b390389b..2f1d6da1bafb 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -648,7 +648,7 @@ static void remove_inode_hugepages(struct inode *inode, loff_t lstart,
 	const pgoff_t start = lstart >> huge_page_shift(h);
 	const pgoff_t end = lend >> huge_page_shift(h);
 	pgoff_t m_end = lm_end >> huge_page_shift(h);
-	pgoff_t m_start, m_index;
+	pgoff_t m_start;
 	struct folio_batch fbatch;
 	struct folio *folio;
 	pgoff_t next, index;
@@ -670,7 +670,7 @@ static void remove_inode_hugepages(struct inode *inode, loff_t lstart,
 			 * due to a race with fault code.
 			 */
 			freed += fault_lock_inode_indicies(h, inode, mapping,
-						m_start, m_index, truncate_op);
+						m_start, index, truncate_op);
 
 			/*
 			 * Remove folio that was part of folio_batch.
-- 
2.37.1