Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220823210354.1407473-1-namhyung@kernel.org> <95708205-66EA-4622-A580-FD234E6CE2DA@fb.com>
 <CAM9d7cgxP6+R2BkVZfRAVvFUaJcknu8wAvKa_b1TBnTdKKiQvw@mail.gmail.com>
 <6305b7e7c7709_6d4fc20869@john.notmuch> <CAM9d7chYaeHvEkq2zCKeA6FiO0wfC2LCGc-1Sj=KdS8oU-2iFw@mail.gmail.com>
 <E6872BF2-8DB9-4D42-957B-E57EAE28AA65@fb.com>
In-Reply-To: <E6872BF2-8DB9-4D42-957B-E57EAE28AA65@fb.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 25 Aug 2022 10:21:36 -0700
Message-ID: <CAM9d7cijLEKmBMs5M6A02GpsEPJoqxOj6+VCuaE=ae8R4VseWQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next] bpf: Add bpf_read_raw_record() helper
To:     Song Liu <songliubraving@fb.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     John Fastabend <john.fastabend@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>, KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 25, 2022 at 10:05 AM Song Liu <songliubraving@fb.com> wrote:
>
> > On Aug 25, 2022, at 9:57 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > On Tue, Aug 23, 2022 at 10:32 PM John Fastabend
> > <john.fastabend@gmail.com> wrote:
> >> Namhyung Kim wrote:
> >>> Ok, now I think that I can use a bpf-output sw event.  It would need
> >>> another BPF program to write data to the event and the test program
> >>> can read it from BPF using this helper. :)
> >>
> >> Ah good idea. Feel free to carry my ACK to the v2 with the test.
> >
> > Hmm.. it seems not to work because
> > 1. bpf_output sw event doesn't have the overflow mechanism and it
> >   doesn't call the bpf program.
> > 2. even if I added it, it couldn't run due to the recursion protection by
> >   bpf_prog_active.
>
> How about we enable some raw record for a software event? Something not
> controlled by BPF?

Only for the test?  It'd be nice if we could have meaningful data from software
events but I don't have an idea what data it could carry on which event.

Peter, what do you think?

>
> If this doesn't work, a self test that only runs on some hardware is also
> helpful.

Yep, makes sense.

Thanks,
Namhyung