Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a151e3d3-db1d-c3ad-dcd5-3f758b4138ab@oracle.com>
Date:   Thu, 25 Aug 2022 10:27:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] vmcoreinfo: add kallsyms_num_syms symbol
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Dave Young <dyoung@redhat.com>, linux-kernel@vger.kernel.org,
        Vivek Goyal <vgoyal@redhat.com>, kexec@lists.infradead.org
References: <20220808205410.18590-1-stephen.s.brennan@oracle.com>
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
In-Reply-To: <20220808205410.18590-1-stephen.s.brennan@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHFkSXp1dWF6R2cyNEN6WnF2SENMMXpSSmxscEtIZzBpOEFGVWZzK3R6MjRO?=
 =?utf-8?B?cXpPMGlWVkFqSk85cHA3aTR6NmlDNkZrOXFya2RtMGI1eGZGYmtHMldYL0Er?=
 =?utf-8?B?RSthSDFpWUhjQXhteUUwNkRtYnYvQ2lPTitKQXdUOEdtcFBBVytwT1NRQ241?=
 =?utf-8?B?bEtJc3EzQkJmYjIveVJ5Qjd5Z0lHYlN6RVZYb0tjbkVmN1F3UDFrRnZQNnZD?=
 =?utf-8?B?MXJGOGlvM2FoMkk3WWphRGlkWG56U0VmVGRaemdCdU0vUTZRcGR1YmtqWlRZ?=
 =?utf-8?B?K0V0eXgrUktpeVU0ZzJTQ2xXT0JQTmFWWU5aMklSYnpPTEpqS2xyTms4bXJl?=
 =?utf-8?B?a2tVekRVUkFGR0t1Z1ljaWNxelg0SzFZUVdlSkFwUEp1UUVCcGRzK0tGWEda?=
 =?utf-8?B?LzRVeVRqVjhtSkdmbHRxL3FBM05lWDJLUGlvVmxlNGk1WUFLcVg4SlppamUr?=
 =?utf-8?B?RlNNbXkxdTVvQ3hGSGlqVm9Ya21sV3g5dmx0ZmF3MHBIQ081WFdJYnZWNGI2?=
 =?utf-8?B?NnNYbDhpRnpXcG8rNDR6c0lvVlh4S2JzNlF5dkx1dEcvL1RnbktBTlgyTWkr?=
 =?utf-8?B?SGl4YkNnUWFvb3VtcGhXRi9SQVBIaUtYQWo0KzYvNU8xcXc5L1l4ZU96OUJa?=
 =?utf-8?B?dCs4TjUxZ0R4bFdTQmY5cWxCbWZneDh1akg4aVVtK1ByS2krRisrdkthZVFq?=
 =?utf-8?B?U2JYYmVoaWVscFU3WlJBd3ppSzRxWFNrcThXUnI0ZE42TEd1ZHZOcnQ4MEdW?=
 =?utf-8?B?TGhzN2RUSjZvZ3FUb001YVZRNVJWRUF1U0pwdXFWMThsb05UdEhNdU1PQkEz?=
 =?utf-8?B?cFZXeDVYRS9XTHlwYlBYWHNDRVJ0bFdDYnRFMkFCZEtjanJBSFFoSkZzUVBi?=
 =?utf-8?B?eGdNd2RwRVlta002WnA1N1gvaUJ2TGlZY09mK05Jbm5MZWJHVWZlb2c5T1Y4?=
 =?utf-8?B?NnNraGVXNEpGejNmSk5pSC9oRkYya1FZYlQ1MW9qamp2ZmFYeUFmWC9lL0l4?=
 =?utf-8?B?bC9zZk01TGZYQzB1SFJkeFVsMERocjRjNnBSYmxCcS9YYjNBRHhsUFovL3FY?=
 =?utf-8?B?VXdUWk9IN2t1amtTZlFGcWpwME9jb3FxbkFMbDQwb1BvS2tHYnlXYU9jZEVP?=
 =?utf-8?B?MVpLaS9vcHVBZ0lsT2UrRWpWZlFyZVJia09QMWE2VnFEckVzZEZFNjhjZFgx?=
 =?utf-8?B?aDlWSlRzejl2c3FUQWZiT1FzRXRMR1kzTDJGeStNQzYvVms3Z0ltTk9iVnNU?=
 =?utf-8?B?WjR1NzZub3BZdlhPaU1IWTlNNm5pekJKREdYWmhGQ0JyeHpNNFhTZ3J5UHBM?=
 =?utf-8?B?NU8vNzN5VFd0VHhodUp0U0JvalVUUDUyZGxJN0V4WHZScG85YkdiMXFwVi83?=
 =?utf-8?B?V0NyeDBYVmVzelRFdWRVd043Z3dGYm5hVGNZK3BGNzNWdkN1OFNTUzZCWGVI?=
 =?utf-8?B?MXRiRG4zak9PKzdBaCtNQ3ZtSUMyWXFRYzBiNCtaQWx1WUVIaC9ZZE9PU0k2?=
 =?utf-8?B?RWJEb3ZNWmFLdjQzeWxUNEFBL0pBOFBoWWI0RkxqSDZSbk1sWG9GenhjNU9N?=
 =?utf-8?B?aHdIM2hTSmJzdDE2YWJSUy9sby8xVENWdVd5N0thbVJEUEZuRjFIaWp3elAr?=
 =?utf-8?B?dmlscDNJYm80N3RLbHkrbXQwQXE1NG81QmNVaHBZSXd2VWc5bXljWDU4UVU3?=
 =?utf-8?B?ZG1zem9ZWGxyV2RWQlJ1RkpNS3NxK3RyNFM4bHpoQVN0VURNeW1ZVFZwWCtV?=
 =?utf-8?B?VGViaUtZWHRXOUl1ZUJtN0U0UlRmcEJray81QjM1cE9YNmNGbktJS3dwWWhj?=
 =?utf-8?B?TlM5MS8xOVg0OEdzSnlPSXZmbUl5ZVRsR1ovVjEzamRvTEpobUxFaVlJdDhV?=
 =?utf-8?B?dEVKaTIremMvalEwdU5lZGNIb3k4K0tMekxLdTMrbHZqdjlrbGg5MFJDZ2xM?=
 =?utf-8?B?MXliSlRGWkhwWDg4M1AxR3FrVVNaeG41NS9tZW91dkJnZU55TnVPNnVVTjFI?=
 =?utf-8?B?NHFIUVJjZDlsY3RjanlOOFcrSWdqVXo3RjVUZ0xrUVhqakZ4Z1pnS0VZSm96?=
 =?utf-8?B?VVdvdFJKenVjYjlZU1NYdGpQZzFkZDl5VzdHRTI4dWJUV1FzdGdOaE1hc1Nu?=
 =?utf-8?B?ZU5aYTZ5SFJHWUJQaTN2Z04rb0l2a0l4WFFtMDZYcnUyQ0ZNYjRDNkl5SDdh?=
 =?utf-8?B?cWc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3c392da-c0c9-44ac-d171-08da86bf086f
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 17:27:06.6642
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: leohu+PVHy7BXlkGJOv5KNGt5Vq1R8EQJX/3ACpCACDmZOCdr9NjccDaxFloYBc6o/H7uiyUHiVFNH5ozwSkxzeTFXcIiIpNPKZw8DTVOSw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3310
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-25_08,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0
 bulkscore=0 adultscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208250065
X-Proofpoint-ORIG-GUID: ACzPFgQQ7DpQ3MEeoLuUrRnRZxo-bUdP
X-Proofpoint-GUID: ACzPFgQQ7DpQ3MEeoLuUrRnRZxo-bUdP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

I just wanted to check on the status of this. I got your email about it 
being added to mm-hotfixes-unstable, and I do still see it in the quilt 
patches set:

https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/vmcoreinfo-add-kallsyms_num_syms-symbol.patch

I see the patch in mm-everything-2022-08-15-02-47 but it seems to have 
dropped out in mm-everything-2022-08-17-20-59 and later tags. As a 
result, it no longer shows up in linux-next.

Please excuse me if I'm ignorant of part of your process here, I know 
you handle a huge volume of patches!

Thanks,
Stephen

On 8/8/22 13:54, Stephen Brennan wrote:
> The rest of the kallsyms symbols are useless without knowing the number
> of symbols in the table. In an earlier patch, I somehow dropped the
> kallsyms_num_syms symbol, so add it back in.
> 
> Fixes: 5fd8fea935a1 ("vmcoreinfo: include kallsyms symbols")
> 
> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
> ---
> Hi Baoquan & Andrew,
> 
> I made a silly omission in the above mentioned commit, which just got merged
> via Andrew's non-mm pull request yesterday. I must have dropped it as I
> cherry-picked between versions. Would you be able to queue this up with whatever
> fixes you'll send for the 6.0 rc's?
> 
> Thanks, and sorry!
> Stephen
> 
>   kernel/crash_core.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 07b26df453a9..a0eb4d5cf557 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -494,6 +494,7 @@ static int __init crash_save_vmcoreinfo_init(void)
>   
>   #ifdef CONFIG_KALLSYMS
>   	VMCOREINFO_SYMBOL(kallsyms_names);
> +	VMCOREINFO_SYMBOL(kallsyms_num_syms);
>   	VMCOREINFO_SYMBOL(kallsyms_token_table);
>   	VMCOREINFO_SYMBOL(kallsyms_token_index);
>   #ifdef CONFIG_KALLSYMS_BASE_RELATIVE