Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 20:47:28 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     kernel@pengutronix.de, Andrew Lunn <andrew@lunn.ch>,
        Robert Marko <robert.marko@sartura.hr>,
        Luka Perkov <luka.perkov@sartura.hr>,
        kernel test robot <lkp@intel.com>,
        Jonathan Corbet <corbet@lwn.net>, netdev@vger.kernel.org,
        linux-doc@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
        linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        David Jander <david@protonic.nl>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v2 6/7] ethtool: add interface to interact with
 Ethernet Power Equipment
Message-ID: <20220825184728.GA2116@pengutronix.de>
References: <20220825130211.3730461-1-o.rempel@pengutronix.de>
 <20220825130211.3730461-7-o.rempel@pengutronix.de>
 <20220825111019.1dc3dae0@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220825111019.1dc3dae0@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Aug 25, 2022 at 11:10:19AM -0700, Jakub Kicinski wrote:
> On Thu, 25 Aug 2022 15:02:10 +0200 Oleksij Rempel wrote:
> > +enum ethtool_podl_pse_admin_state {
> > +	ETHTOOL_PODL_PSE_ADMIN_STATE_UNKNOWN = 1,
> 
> Why define UNKNOWN.. as 1? No real objection here, just in my head
> somehow UNKNOWN = 0 or just start from 1.

I need to keep difference between not supported functionality and
supported but unknown.

> > +	ETHTOOL_PODL_PSE_ADMIN_STATE_DISABLED,
> > +	ETHTOOL_PODL_PSE_ADMIN_STATE_ENABLED,
> > +
> > +	/* add new constants above here */
> > +	ETHTOOL_PODL_PSE_ADMIN_STATE_COUNT
> 
> Why define count for a value enum like this? For attrs we define it
> because it's used to size tables, don't think anyone will size tables
> based on states.

ok, i'll remove it.

> There's a bunch of kdoc warnings in the patches as well.

ok.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |