Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp959029rwe; Thu, 25 Aug 2022 12:21:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR7hZcy5VDY30VfXpt4XEfC9zOTQ9H7uKT+iwMnO615wxHV6Zhev7G1EtqqL2j9zFSCQmFLY X-Received: by 2002:a17:907:960f:b0:73d:5b08:68b9 with SMTP id gb15-20020a170907960f00b0073d5b0868b9mr3394286ejc.337.1661455298868; Thu, 25 Aug 2022 12:21:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661455298; cv=none; d=google.com; s=arc-20160816; b=QoKpUnVvVhO/JxziPhcXDwQdNBdZMXhEWWiaKDFzYKd40rdGFpvgiSCdYvrxJubjSa /aVlpbF7e2YhivKXkZjoih5v3saLTd798hLL/r6oSGC2J1BiUmxwlD1tHuBpSLfNu94V 5rFWNc4BmcbbnLrcOcPUPl6IQUdkZ3nXA3dnqgGRtDsTFJFjILu/z0pPLEojw4wuPSvk 25BN21k1bbFhH07zE5FRMPCuZA/vCo7RYraOe8RpAgfv77R5UyBCu1D7iaecJ8r7D78x Rus7739IffGs6HqormVl4U1cfZ+vX46nwCWlMxY1JboTuBtko1nGakSXN+XXs3BpDyBw CZww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=vIKilItQAy1ozzsTadHUeXdxZ7O+1t0EvaKuKW9NY00=; b=z+aoTdhGafHeu6qCfMRI2lJGC6Q9KiNmabTLOA0MbjJz8p/2F01AnIMqevjCGLpN7O qPTBJwQOSKnCHL+XGg+kHxzgNEngBne2NaartieMyB01czyS4jiQEIg1lFgJmMTssi6i ki5rUxP7RqqE2ebMqk7ajH/m6G9VSNjHe1XLSRJxx8MA39dsvzr4GTYhl5YlngSL03as KNQyiX9L25Nl/fMI5m8bCbMPc7T8jiNSbVPyLrexJ0yzjYnXUuBCkbSktjYEQ8quEiV5 r6Fx4NIVCCagxWuo8FP0kBUwC+V4Mx63PgFrXnmxX3fkOoQWFeraT7OE5HZ+B6y3DUxY 9T/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c3UkDop3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa41-20020a1709076d2900b0073150f3dbbfsi4973045ejc.950.2022.08.25.12.21.13; Thu, 25 Aug 2022 12:21:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c3UkDop3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243273AbiHYSKl (ORCPT + 99 others); Thu, 25 Aug 2022 14:10:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243250AbiHYSK3 (ORCPT ); Thu, 25 Aug 2022 14:10:29 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16FA4A927A; Thu, 25 Aug 2022 11:10:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id CD716CE292B; Thu, 25 Aug 2022 18:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D623C433C1; Thu, 25 Aug 2022 18:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661451021; bh=Er8V9jNbcvkm1yktE0q1q+gaOywFHNbKENwzjuzsnpk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c3UkDop3oO43oJhqNyBuSPAFSouev7/BICPgYp4oeVQB4vqSSZ3dTBFcoHV3jR1eg 02FgisMPYnCaKBwXe2JuSpOLV/FrZsifmSq5LDmChTtAZUsp/BQOKdfdGgclTziAfn skf6YPayTB9zEuhxk3tqYH0FpwKxra/psXWasHQUrk5QJ9TMt35wbw38k3jTUe0G/Z LVaZKqorz5gAvzX7bm81C1ngf63fn4uGWm1EfZsptc1k5GAFONdPWkN7hoPfBDDRvt mEAbxWTNsIfpJY8y1110qJwW1nuFR8rqMT9x/IUgNZjkgigBvkBhjsVWuxQSvksJKD 8q1z61szHCW5w== Date: Thu, 25 Aug 2022 11:10:19 -0700 From: Jakub Kicinski To: Oleksij Rempel Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Paolo Abeni , Russell King , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , kernel test robot , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, David Jander , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v2 6/7] ethtool: add interface to interact with Ethernet Power Equipment Message-ID: <20220825111019.1dc3dae0@kernel.org> In-Reply-To: <20220825130211.3730461-7-o.rempel@pengutronix.de> References: <20220825130211.3730461-1-o.rempel@pengutronix.de> <20220825130211.3730461-7-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Aug 2022 15:02:10 +0200 Oleksij Rempel wrote: > +enum ethtool_podl_pse_admin_state { > + ETHTOOL_PODL_PSE_ADMIN_STATE_UNKNOWN = 1, Why define UNKNOWN.. as 1? No real objection here, just in my head somehow UNKNOWN = 0 or just start from 1. > + ETHTOOL_PODL_PSE_ADMIN_STATE_DISABLED, > + ETHTOOL_PODL_PSE_ADMIN_STATE_ENABLED, > + > + /* add new constants above here */ > + ETHTOOL_PODL_PSE_ADMIN_STATE_COUNT Why define count for a value enum like this? For attrs we define it because it's used to size tables, don't think anyone will size tables based on states. There's a bunch of kdoc warnings in the patches as well.