Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 13:03:38 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V2 1/2] PCI: Allow drivers to request exclusive config
 regions
Message-ID: <YwfVmlissGgXo+Y8@iweiny-desk3>
References: <20220824232450.723179-1-ira.weiny@intel.com>
 <20220824232450.723179-2-ira.weiny@intel.com>
 <Ywcl6HPZ4HYCc641@kroah.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Ywcl6HPZ4HYCc641@kroah.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9D46ZmQf5DBrTNZLRJy8V9tcpDfzDDepJ1o1zehPTqvchm/DbHKUvEZZ7JsS?=
 =?us-ascii?Q?sakT2WH28OwWuTpGW1KEQsXRTOvBIiHxG8czT91wUEbkc9DtAHL5ngbvzBKv?=
 =?us-ascii?Q?WFnf1P8gG/s3xp8gK5ErliTCiOPdNrW2o86l07OR2RnzhTD4S/RSa0TOgE/Z?=
 =?us-ascii?Q?0HAQoYJaE9n6sA8orF1AIVKZMF4NiQvxxFAi94vW9mSozn6jRmtVdC+xyzw4?=
 =?us-ascii?Q?UDC+ubS8977xnrcv+sqX3jkzjztACxZ8xJD487ZwPYB7PHTVJr+feLHab9ag?=
 =?us-ascii?Q?hrjo3fXpgzMuF84dLkftO/IV16KJCI4Svg63g8tjPeKo+7Z7CSLBcM+6fiKN?=
 =?us-ascii?Q?gyPTUxOnS3X3tpILMl7lRBVrV49u4LIXPjJTwoXq31LPLg4BYLF/xtxu+/cl?=
 =?us-ascii?Q?AiXRPRSCO4Z7oKbDUbSavrUsbft/FRCC2uhKXVQOYhvSLerhCOU4610As2Md?=
 =?us-ascii?Q?90TlCnhUA1jirkvXhb4fRphZ1Xnu/RLaAFx4pn/+geFdj2sStqSVEsVZbySp?=
 =?us-ascii?Q?135qqi+ueaflVgxzfF6lQ4fHxw7FvfikJgIIbkYQ4oYkjB8vlzEHm8cf4ySy?=
 =?us-ascii?Q?sblVQ7UnCP8RliGMsoOZ2Vx1lqaWp/a8qz66yfzzGRJbCX/tXgv+O5G/ZEqT?=
 =?us-ascii?Q?c5CuW6rdKMw/7XwKk2G05Nbcp+ykddlJLhJQQmCuTqRNyw7M1tqJrCnoBdBp?=
 =?us-ascii?Q?8fePeBwyPWNvRVjgAkTPzv+UNajMRSADoRSUIXReTvHrOA6dlWdxOiEFI9Dd?=
 =?us-ascii?Q?dYOW/zAX75Nv0iXvkp1VvmZNVep71RMk5dGneuHmEyTtmoI5h0z/tx6kke9f?=
 =?us-ascii?Q?GAhmhqwTAKp/3xZ8HTLxX2Cc466PL76T0SMSrAL4FgNz2z5oTCe0Bya3hIRk?=
 =?us-ascii?Q?qFV0PwtVZBM2ZkCIAsfOSq1snYNxKnvv5o/92vrZwVBtUw1gApCRnr9nzjzS?=
 =?us-ascii?Q?Hx+w6HGZwoyZhyGASIh5y3KeWbKkbZrZkK4tKV8dKtagGIVKzvj2bWuSsXFM?=
 =?us-ascii?Q?c1y9u/yWj2GnvWh1mGFUZtpZNS5zNstUYMgxoVOwPMkICqTzF4tPkh5L5uL+?=
 =?us-ascii?Q?xqlnUDjy4mkcjLlbe+H5FKvmU+8zniElJ//eXgb+9YmGJxvkKsDV3PhIzwbe?=
 =?us-ascii?Q?yZIk/KZ7Bun9ZkYkIRPCsxxjNchV2Z7dNp7kulX7w96VbS9ihpf8syT4WlL1?=
 =?us-ascii?Q?lJzyMkwWN+qZDuxr4XszvIMaCKU9I2vQR7gAAXWHr2qTeFvn2oGS2PMt62zS?=
 =?us-ascii?Q?zTbSgxcYsYV+0ad3U8cms0m7KpnhA2EAIzRl3rslI3n53ZS0PqLAltTIQ3xw?=
 =?us-ascii?Q?PHjkSrU6pFiWSSR/TkPTfXT5vpLggOIHLzpTDp4b1szR9Ol4Nr9CvDn7jbnl?=
 =?us-ascii?Q?D3k5cEsL54892Z5eqsdTttcXxuC6jrIjiL+YKPS3ux6wp5FsyoSQbQNqRvAq?=
 =?us-ascii?Q?4yDcrvKf0KrKZirpwQcoadIyJ7JMCgOIE1YJpx3fxHmTHNBW2sT7oUvccLJ/?=
 =?us-ascii?Q?BAjR+xAyZCB5SXgx+mDbV5qpmNFfO2qnz+3b6S+1EMvUHmYWhowh4/nupqUX?=
 =?us-ascii?Q?g4AABJrp++653sg7U9nd5bZoLHAK3CDSgzd/05RD?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 73bb8e15-4565-414c-3fff-08da86d4e8df
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 20:03:42.5897
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rLkAqJHIzPKqNZg/7HsvMvWx4CHf1ImUaZKOyd8qHBz2P83NJ7O9MWpOimcV/8fdXVD+L9wf04IGlzUfTAyWNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4523
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 25, 2022 at 09:34:00AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Aug 24, 2022 at 04:24:49PM -0700, ira.weiny@intel.com wrote:
> > --- a/include/linux/pci.h
> > +++ b/include/linux/pci.h
> > @@ -409,6 +409,7 @@ struct pci_dev {
> >  	 */
> >  	unsigned int	irq;
> >  	struct resource resource[DEVICE_COUNT_RESOURCE]; /* I/O and memory regions + expansion ROMs */
> > +	struct resource config_resource;		 /* driver exclusive config ranges */
> 
> Naming is hard, but let's make this obvious what this resource is for as
> your comment states.  How about:
> 	struct resource driver_exclusive_resource;

Done.

> 
> Other than that, looks better to me, thanks for the update.

Thanks!
Ira

> 
> greg k-h