Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1007173rwe; Thu, 25 Aug 2022 13:27:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR5F3MZ+YM8vmx8i79IkQlTgJYplk61+yx3HmD7MuQYpl3jXuavfNi8QvDEWozexr7phuKek X-Received: by 2002:a17:902:8d83:b0:172:c4f6:aa84 with SMTP id v3-20020a1709028d8300b00172c4f6aa84mr722060plo.67.1661459245478; Thu, 25 Aug 2022 13:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661459245; cv=none; d=google.com; s=arc-20160816; b=iYhgsj0GWU97kaZ22Wzl43Wbg/4sokmLv3u5BvXWUmMJxrBpGKIowdJEa+sTMMTUa6 +NS4nYJZrWZE5C6npRxCN2Cu6nDoufLo0ar1/YA8Kr2gZmMM7lf3CZl+bylV4aL8FLP6 H4qGcSHvEv4XMhvS4bF1qk2Y7aPbIkt+M6Ii+Ht+NRE2HtW/xx2tDPvfS3eevVOd1uh0 MHfoeQlzcWVQ+nBQl0UUm5r9amCkVyGVt9jigVOb95lNkkrTk0/9OQxx9czDbRyvnCZN vT3UZJonHW8eMx0siEczg42Pr/QkEYeHaSYbSO3drl8yK+oKlT5JONbuyQfEIi7ZXhwR 1Y5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5SXUIhrjauVS9CJyRq7oSmWzAiCW3NIz2CQaiUbjGBA=; b=pW7q1Sm7esYrgFekZb68mLPpmGHUlaLo7LnMuU9vIzv1keLmB0begho5AhpbROrnKD e+Cx/jZWshR/s6rmopQ3d9qV8LRZvoh29EyWO07atHuwrshqv4jejPh1lgE2IIkxCGCh PXOESE6wg9eowuv+elGYxZS0KPRipitFEK2tipPxciEXElZCsf39QB4C5l4SOlPAKbUw i1Bx1wBxhQm2kufbDt+4U3jC8+gR0fYuuEdaOKOYVf6uRfUT/hnOdMk8QDB29kzGJ7/h Ntgw0hhopb6NfvkmyWZ37LUMByKSL1wpvN8o+ZlKWavKwwTZnZIH3uUMG9gAz2ehgFEF Sesg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=l+MrObVc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s23-20020a170902b19700b0016c759a35c7si19746816plr.317.2022.08.25.13.26.59; Thu, 25 Aug 2022 13:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=l+MrObVc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242716AbiHYUQi (ORCPT + 99 others); Thu, 25 Aug 2022 16:16:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242525AbiHYUQg (ORCPT ); Thu, 25 Aug 2022 16:16:36 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F879BFEA2; Thu, 25 Aug 2022 13:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=5SXUIhrjauVS9CJyRq7oSmWzAiCW3NIz2CQaiUbjGBA=; b=l+MrObVcs6pWde33MQC6/Ghw5u xeG22J5XSpZI7PQovIJOs/vMXIFIXR5ND7f3YZbt1NJ76E4xzEa/sIksJUrKZSlgWdtv2WhinNZjo kTsPNCPrv+yXNE8HD0hUKYEhONNS4O17PP3SFPnF719qOt0zNzTYK3FTCvEUWZ13augo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oRJHD-00EbSr-6f; Thu, 25 Aug 2022 22:16:31 +0200 Date: Thu, 25 Aug 2022 22:16:31 +0200 From: Andrew Lunn To: Horatiu Vultur Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, michael@walle.cc, UNGLinuxDriver@microchip.com, maxime.chevallier@bootlin.com Subject: Re: [PATCH net-next v2] net: phy: micrel: Make the GPIO to be non-exclusive Message-ID: References: <20220825201447.1444396-1-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825201447.1444396-1-horatiu.vultur@microchip.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2022 at 10:14:47PM +0200, Horatiu Vultur wrote: > The same GPIO line can be shared by multiple phys for the coma mode pin. > If that is the case then, all the other phys that share the same line > will failed to be probed because the access to the gpio line is not > non-exclusive. > Fix this by making access to the gpio line to be nonexclusive using flag > GPIOD_FLAGS_BIT_NONEXCLUSIVE. This allows all the other PHYs to be > probed. > > Fixes: 738871b09250ee ("net: phy: micrel: add coma mode GPIO") > Signed-off-by: Horatiu Vultur Reviewed-by: Andrew Lunn Andrew