Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220825194604.15645-1-jagathjog1996@gmail.com> <20220825194604.15645-3-jagathjog1996@gmail.com>
In-Reply-To: <20220825194604.15645-3-jagathjog1996@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 25 Aug 2022 23:23:05 +0300
Message-ID: <CAHp75Vc5048aQL5cLy-OfBfnH6tz_7z24sFX2H1oGRz+JUyq9Q@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] iio: accel: bma400: Add support for single and
 double tap events
To:     Jagath Jog J <jagathjog1996@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Bastien Nocera <hadess@hadess.net>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 25, 2022 at 10:46 PM Jagath Jog J <jagathjog1996@gmail.com> wrote:
>
> Add support for single and double tap events based on the tap threshold
> value, minimum quiet time before and after the tap and minimum time
> between the taps in the double tap. The INT1 pin is used to interrupt
> and the event is pushed to userspace.

...

> +static int tap_reset_timeout[] = {
> +       300000,
> +       400000,
> +       500000,
> +       600000

+ Comma and so on for the rest of the similar cases.

> +};

...

> +static int usec_to_tapreg_raw(int usec, const int *time_list)
> +{
> +       int index;
> +
> +       for (index = 0; index < 4; index++) {

Magic. Shouldn't be defined?

Also you may add it to each data structure in question.

> +               if (usec == time_list[index])
> +                       return index;
> +       }
> +       return -EINVAL;
> +}

...

> +       int ret;
> +       unsigned int mask, field_value;

Reversed xmas tree order?

...

> +       /*
> +        * Tap interrupts are operating with the data rate of 200Hz.

a data

> +        * See section 4.7 "Tap sensing interrupt" in datasheet v1.2.
> +        */

-- 
With Best Regards,
Andy Shevchenko