Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 Aug 2022 16:17:54 -0500
From:   Rob Herring <robh@kernel.org>
To:     Liu Ying <victor.liu@nxp.com>
Cc:     gregkh@linuxfoundation.org, s.hauer@pengutronix.de,
        devicetree@vger.kernel.org, geert+renesas@glider.be,
        kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
        krzysztof.kozlowski+dt@linaro.org, saravanak@google.com,
        linux-imx@nxp.com, linux-kernel@vger.kernel.org,
        festevam@gmail.com, krzysztof.kozlowski@linaro.org,
        robh+dt@kernel.org, shawnguo@kernel.org
Subject: Re: [PATCH RESEND v4 2/2] dt-bindings: bus: Add Freescale i.MX8qxp
 pixel link MSI bus binding
Message-ID: <20220825211754.GA1704113-robh@kernel.org>
References: <20220822060323.3481384-1-victor.liu@nxp.com>
 <20220822060323.3481384-3-victor.liu@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220822060323.3481384-3-victor.liu@nxp.com>
Precedence: bulk

On Mon, 22 Aug 2022 14:03:23 +0800, Liu Ying wrote:
> Freescale i.MX8qxp pixel link MSI bus is a simple memory-mapped bus.
> It is used to access peripherals in i.MX8qm/qxp imaging, LVDS, MIPI
> DSI and HDMI TX subsystems, like I2C controller, PWM controller,
> MIPI DSI controller and Control and Status Registers (CSR) module.
> 
> Reference simple-pm-bus bindings and add Freescale i.MX8qxp pixel
> link MSI bus specific bindings.
> 
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v3->v4:
> * Add child nodes in the example MSI bus node of the MSI bus dt-binding. (Krzysztof)
> * Resend v4 to imply this patch is based on v6.0-rc1 so that there are not any
>   dependencies. (Rob)
> 
> v2->v3:
> * Add a pattern property to allow child nodes. (Rob)
> 
> v1->v2:
> Address Krzysztof's comments:
> * Add a select to explicitly select the MSI bus dt-binding.
> * List 'simple-pm-bus' explicitly as one item of compatible strings.
> * Require compatible and reg properties.
> * Put reg property just after compatible property in example.
> 
>  .../bus/fsl,imx8qxp-pixel-link-msi-bus.yaml   | 232 ++++++++++++++++++
>  1 file changed, 232 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>