Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753291AbXFNJw7 (ORCPT ); Thu, 14 Jun 2007 05:52:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751486AbXFNJww (ORCPT ); Thu, 14 Jun 2007 05:52:52 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:54480 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbXFNJwu (ORCPT ); Thu, 14 Jun 2007 05:52:50 -0400 Date: Thu, 14 Jun 2007 11:52:49 +0200 From: Jan Kara To: Badari Pulavarty Cc: Nick Piggin , lkml , mark.fasheh@oracle.com, ext4 , Andrew Morton , cmm@us.ibm.com Subject: Re: + fs-introduce-write_begin-write_end-and-perform_write-aops.patch added to -mm tree Message-ID: <20070614095249.GG17819@atrey.karlin.mff.cuni.cz> References: <200705292119.l4TLJtAD011726@shell0.pdx.osdl.net> <20070613134005.GA13815@localhost.sw.ru> <20070613114356.GD17547@wotan.suse.de> <1181776021.21924.87.camel@dyn9047017100.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1181776021.21924.87.camel@dyn9047017100.beaverton.ibm.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 32 > On Wed, 2007-06-13 at 13:43 +0200, Nick Piggin wrote: > .. > > > > > 5) ext3_write_end: > > > Before write_begin/write_end patch set we have folowing locking > > > order: > > > stop_journal(handle); > > > unlock_page(page); > > > But now order is oposite: > > > unlock_page(page); > > > stop_journal(handle); > > > Can we got any race condition now? I'm not sure is it actual problem, > > > may be somebody cant describe this. > > > > Can we just change it to the original order? That would seem to be > > safest unless one of the ext3 devs explicitly acks it. Sorry, I've missed beginning of this thread. But what problems can exactly cause this ordering change? ext3_journal_stop has no need to be protected by the page lock - it can be even better that it's not protected as it can trigger commit and all that would happen unnecessarily under page lock... Honza -- Jan Kara SuSE CR Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/