Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1149769rwe; Thu, 25 Aug 2022 17:00:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR5Gm89HSPAJAHGpwGrMwy2Z7EW6aEqB58R/B5stXL9yszCq6eM3ExcvxWGLm+87ZQbJqXoE X-Received: by 2002:a05:6402:4504:b0:43b:4ec7:2ec1 with SMTP id ez4-20020a056402450400b0043b4ec72ec1mr4829913edb.7.1661472038742; Thu, 25 Aug 2022 17:00:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661472038; cv=none; d=google.com; s=arc-20160816; b=BWjeT7eeovkAdYAHAr1gBQLuppbZAON3WLtl4ddSQnJy8xd/wEHkb20a03PgjJy7r7 H3HSOopnM8WRfLs8r0bM0ofK9CJkMqhTWeBWGnATmduvgrbTTFdhU+mnOe10wjHZHBNx aeWOC5wSzOI/yvjj9wSgNDrktXyTyMNwiFwf2R4DKPMacrb2ccbHjGwbu6eQoT6RiqgU HsV7/LvsPmq6vOob53CWnYGuxVwYMgRU6M7twtbmauGRL2Uh02giGo1GvyJxUiIKxlXu PTX3Q67MtIsmMVTHhl65t/AGNegCaZ9CW0NUi1RWShulwJKfYf9V8u/nk50/LWzlPEP6 h4Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PdaXudCOGj32vCBzYEwKoFsRR206fL59N9F6XcpqUXg=; b=DJiMzk57EHNYr2lS30xbMNiOM/ymjs2ge0HlMMqPqjVHAe5Rh8nwe6VdzmNk9hcWoG 4hJc/KmtwiA11X9u/R3+I8peCsL80w5nr/lq94BJquq1c3CP81n7/u8Ucgwo3p79JH0v vCTQPPuiWxqBULKnBAGZq9FmCD3NzUuKvQ2xhFsCcypzNh6dMR5ATTXePdsacwn1sP4l DsOjHN239jbDGEQF3DQJAX3OuGEUhIg9YB++ZATlDsrs/gjlhX8xzcdlzmL10JoEbq7w YByCagLlQz580j7d2jUqS+7+y1qPcKh7ps4Ldj4tiqZrXdF8ePOkgh0PkZoRH/tc9ACE pNzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=M30XLzIG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jr19-20020a170906a99300b0072aeac5f74bsi321495ejb.119.2022.08.25.17.00.11; Thu, 25 Aug 2022 17:00:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=M30XLzIG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241057AbiHYXxu (ORCPT + 99 others); Thu, 25 Aug 2022 19:53:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbiHYXxs (ORCPT ); Thu, 25 Aug 2022 19:53:48 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77009C59C2; Thu, 25 Aug 2022 16:53:46 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id bj12so140698ejb.13; Thu, 25 Aug 2022 16:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=PdaXudCOGj32vCBzYEwKoFsRR206fL59N9F6XcpqUXg=; b=M30XLzIGsB2C/iLNsRciX+9IawIJSA5wmdwkD99xptGasxI+N2kPZIjv+uxjmaGL5W ut3nFeiNi5fIgwfbYoLVEGRg3lbFrgR/9sAe9s73hEIkl6uNkEGGgwCG1mSB1oHRIrvL 5xTyav3WgYDuebrxRykIeayUw3S6Jm3V0Hlj1RZ+O7dW0sMt3fX1drSDWlhIfI5dwtnC pCf2AT96mAqF5qwViL4uwsq2Zi3gV/yFgzpqwAkqHyBP1lgiD+ZtpraNPIgT1JYwxlhs gIRSJXgofN4ej2zioxCt1TGR9bi/wCFw8MQvmyu91hUgz+yK1gkUjsdJwPCCx7UjyPv4 ReYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=PdaXudCOGj32vCBzYEwKoFsRR206fL59N9F6XcpqUXg=; b=alE0yZ2oL6tfCgtiXbml9CagyRACuCp3tNEDv7kOKkhlungMFD/du0Rhd3xd4wG8w4 /Z79e26SoG+MgZRlAE4HLxA+oM384w6J7rjU1hhxEkLxu98+Q4V2G2ACgLa4t7HGCAEo 4rhN+zh14ylyLr1UBNo74h+T6nN/4fJXGc1AjiIXbHj+zCy94YWaUIoco1KVL+9Dh7Mu QaGuja06TM4Ie+Unbe4VRqiJc2UuRkb74v2fDaXF8EChZLvsBZExgJ66s57muRQBcBGT iiWUeyhkHP3ZVmEMiqkegSUc9WcTEdYI0/QehPkZGkfT8WLITuZF05lyf18ket4ktLmJ HwuQ== X-Gm-Message-State: ACgBeo1ajXk6ZkUNCttV2JeBbkGZVu2p7ivSaAop48HJI5ZVvveUS4h/ vpCgu0NtwtFsyQDD5iuPqYQ= X-Received: by 2002:a17:907:6d9b:b0:731:1135:dc2d with SMTP id sb27-20020a1709076d9b00b007311135dc2dmr4017180ejc.76.1661471625077; Thu, 25 Aug 2022 16:53:45 -0700 (PDT) Received: from skbuf ([188.27.185.241]) by smtp.gmail.com with ESMTPSA id n26-20020a056402061a00b004464c3de6dasm419978edv.65.2022.08.25.16.53.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 16:53:44 -0700 (PDT) Date: Fri, 26 Aug 2022 02:53:42 +0300 From: Vladimir Oltean To: Christian Marangi Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next] net: dsa: qca8k: convert to regmap read/write API Message-ID: <20220825235342.ofqedobcb6jg5bxz@skbuf> References: <20220806192253.7567-1-ansuelsmth@gmail.com> <20220806192253.7567-1-ansuelsmth@gmail.com> <20220818165119.c5cgk5og7jhmzpo6@skbuf> <62ff7b28.170a0220.91820.52c8@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62ff7b28.170a0220.91820.52c8@mx.google.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2022 at 01:43:57PM +0200, Christian Marangi wrote: > On Thu, Aug 18, 2022 at 07:51:19PM +0300, Vladimir Oltean wrote: > > On Sat, Aug 06, 2022 at 09:22:53PM +0200, Christian Marangi wrote: > > > Convert qca8k to regmap read/write bulk API. The mgmt eth can write up > > > to 16 bytes of data at times. Currently we use a custom function to do > > > it but regmap now supports declaration of read/write bulk even without a > > > bus. > > > > > > Drop the custom function and rework the regmap function to this new > > > implementation. > > > > > > Signed-off-by: Christian Marangi > > > --- > > > > Nothing in this change jumps out as wrong to me, but maybe you should > > copy Mark Brown too when you submit it proper, as the first user of the > > bulk regmap read/write over Ethernet, IIUC. > > Should I send a v2 without RFC and CC Mark or CC directly here in the > RFC? This is ready so v2 won't have changes. v2 without RFC and CC Mark, please.