Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Divya.Koppera@microchip.com>
To:     <andrew@lunn.ch>
CC:     <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH net-next] net: phy: micrel: Adding SQI support for lan8814
 phy
Thread-Topic: [PATCH net-next] net: phy: micrel: Adding SQI support for
 lan8814 phy
Thread-Index: AQHYuFmMgzj2knw/J0+AGHw88JSECa2/mf0AgADxdXA=
Date:   Fri, 26 Aug 2022 03:46:55 +0000
Message-ID: <CO1PR11MB477177D2A2B78178B7B71DF5E2759@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20220825080549.9444-1-Divya.Koppera@microchip.com>
 <Ywd28j0TJjW/ZWUU@lunn.ch>
In-Reply-To: <Ywd28j0TJjW/ZWUU@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?laRAFNRVESNd0xlwoBsSggzsFOxWxRouscJr7/UiHHtctRr4/mJpdRTSlbGx?=
 =?us-ascii?Q?PdakMZftP2mkm7cRsBiSszN79QiKZcJXnEP4m8d0T+IGYzxbet8xXdUbmaeh?=
 =?us-ascii?Q?JZGvGxLPnSCAf7+bZRnlwS+RB5FZ/IrB/wXhQ/XYvCb9Dcrc5ACueOhHIVJk?=
 =?us-ascii?Q?5/wYMAklwqrCymD/osalBpJCjz9/p0VvP09bCiV3I0S9DbP4GGIjp//7OyYT?=
 =?us-ascii?Q?HLiNqjlNgXgiIlQPAgUDl1GWApoibLNmqJ3x4pfWwNBn+35hJNdAzetKbaZR?=
 =?us-ascii?Q?a2rUbdOHI50ygA1XfztQNx+Bs6mShlUgme1RD5ihZ86HuUtJapLceb2MY2dq?=
 =?us-ascii?Q?V7u79bCCH0knok/aRusxIi6OgngdCutEw5dSRMvOhW+oT15AqkdKTuea1ztE?=
 =?us-ascii?Q?w1ZOZN36fCsenIqT1ef+IEyiL79ui2i8Jeq8eB3lg9k/2sMfmhalN759qzEi?=
 =?us-ascii?Q?6es4TvSQEGdfweqkzuShfQTpOxIssBhG745GaJ1W0eIA/1M4iXPSpUvHlExG?=
 =?us-ascii?Q?rG3wFNhUog4kjTgm+oYeUyhQiQUlRkg/uxN+cksWP8KFOPPTFrdaC+IMUfW7?=
 =?us-ascii?Q?9aHHjQtg6a4e9+qysXFn3X3pumZrUQHb4Q7fafFSsqOUGnfHmU8m27BzFjft?=
 =?us-ascii?Q?TgH0Mm0ZLAxQ85O+Z2XNrOvBvPpiHcOQQcDXptOz42/3qrtBccamOsgSx6KH?=
 =?us-ascii?Q?a+VRF0UlYabZiGhW8VXr7bTVAaWHty7zXs5mk58GW8efB632t6Ng7xbyi1wx?=
 =?us-ascii?Q?DcFL7Eu/GqESC9ZAH9MZhPrJp5En19dbdgIORUlegMw/ho884fGbKJJeH3px?=
 =?us-ascii?Q?uuPkAhEHbiBJYJMymQgRM2wHFDpNw3ChaJgnzi2TqcuYj2ubwwVv5dIkVfYv?=
 =?us-ascii?Q?f46IPJtgpgK8gVzYRRDO+jFgSW5dohU0u+ykzr1wQySd3TdVx3tPTQBHuLX+?=
 =?us-ascii?Q?xMbOkfPNYsJzmUS0fVTE5sQgCmYIXCHrP9HfhGI9FPJAV32xcn4tEyIg4S31?=
 =?us-ascii?Q?66KK8S67dtvQlV/c+npCNdvRWgjrgpZNYa+si+2i6izoP8cRtw3f1RcimnoZ?=
 =?us-ascii?Q?VAC13DRiIi/xEclPRJw9Ru60WBiuNuB49QUWNJoMzg/NlO+RalrBdNWPgSAU?=
 =?us-ascii?Q?JU8A6TPtjXQVrgdabMJZEmUtwuMczgblyTIDvzB7lriauT016wAeuOGBwd6H?=
 =?us-ascii?Q?gUDV8pyFYb8/8HGSAwwtjG2ibvCECvgT7wowEMlzMLIk4i1FEYx8nRcyk9Dd?=
 =?us-ascii?Q?gZw7dY1x6lJT24kA+jWSAAmSc6AZbzWZYty9R1gaQHPKoAZ7s2Sg6JFF+lIA?=
 =?us-ascii?Q?+7oUdeLeapNkB+kVOIjAnCi1jwAsChFB5n42aI3cwJCYWo4wc+5UDrEtSGAx?=
 =?us-ascii?Q?rOBtR03FyC1hIaqVfFuCrwLwgG3qgg2nH8erZHLXoASzNr4OhtBRa7/akEDh?=
 =?us-ascii?Q?PLD9BwzDl8HZJR3Hk1wDTG8d2o6ycHNPJvNg2wauPV6YiqVT3jkQ7FJ1Ziua?=
 =?us-ascii?Q?0QnKEidH+jfdcxAJkTHYt8TOtk0Vuf3XiS6zJ3bTcv1eWsEkI4Ke9pSIdjPZ?=
 =?us-ascii?Q?0eL1p+eDU+wDO4KCkSn61jupkZoCQOtVL1Y7G8QyZlSaV22HGw1+gj1WtS5Q?=
 =?us-ascii?Q?kg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aea50b25-f168-4433-5d54-08da87159f25
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 03:46:56.0123
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pItXiZSZ8HYLDEm8/k/R2FnUForaaTmYv5O6EDpEmrkSceQ8TUR+B7zwBjGAV3sC/9JxCDNk+4QrnlBRsQPj/mI85z4ida00KkTD6vyNsJg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3733
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, August 25, 2022 6:50 PM
> To: Divya Koppera - I30481 <Divya.Koppera@microchip.com>
> Cc: hkallweit1@gmail.com; linux@armlinux.org.uk; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>
> Subject: Re: [PATCH net-next] net: phy: micrel: Adding SQI support for
> lan8814 phy
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> On Thu, Aug 25, 2022 at 01:35:49PM +0530, Divya Koppera wrote:
> > Supports SQI(Signal Quality Index) for lan8814 phy, where it has SQI
> > index of 0-7 values and this indicator can be used for cable integrity
> > diagnostic and investigating other noise sources.
>=20
> This driver supports 16 PHY devices. You only add this to one. Are you su=
re it
> does not work with others?

I don't have other hardware to test or check. I have only lan8814, where I =
have tested.
Also the register access or register address may not be same for other phy'=
s. The one who has ownership
May provide support for other phy's.

>=20
>      Andrew