Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp74919rwe; Fri, 26 Aug 2022 00:33:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR6xdIsxe74zBqPWi9dnPKn6GYa6dTuu/BkR6E01QvMiGFN9njsTpgQ7DX0QGBKyytdRsnrl X-Received: by 2002:a17:90b:4c8c:b0:1fa:c44f:473a with SMTP id my12-20020a17090b4c8c00b001fac44f473amr3053868pjb.195.1661499236698; Fri, 26 Aug 2022 00:33:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661499236; cv=none; d=google.com; s=arc-20160816; b=LdxGJgf7Y6g7UXPjCiLrMbOJ7aNiBsCr1Vc1DQN5iA2KY0b4SobQqew/SxXRoMmGIa wC827fc+gqhuwri+MQh7mXTcfaZ+JojKFEFZUryx+rB/te13kPVY1Xf/QnR3NIvj8DJ7 ZiTC82PARMLBU8YKv5h+Orl11HYk0QTWGGvt7UvTtzSIi4Ck9/AAak/5Fcr4GXyXnutC JOtZRVC+jLQzLrfw81SVWjYOiqk7mIhQvTxiDW3j2pl8Xr5OCuyl9LAHeoUy4pgHtNkK f7bPQiTnal86UhvAbwEoSaWAgQQWEuYsIdRSBzdJ5LVT+oFiKy8j5sU70tEcx5zDU7Fm TMLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NOhfFVA1UmLe84Uh+dMB9+gq1yebe8DKdIpTJnuKnbo=; b=WtDM62S0U8p2etnyIzNpq6+QzzQFyOlUftXc0qhR1+EYTKBa6atdhq9N9dbqQgcf/u 2RhOO+kpzEkin9ngu3eF07WVH8jBTiMsavyBFBOKipEozvOE7SxIR+zU1gEsZw3In8Kt o1Z655hAPCOdRyEROjWBuc5tENk08jkvdTnWVcYuZckRn9m9/Nu1r7uTuyY2mA4qSO3+ Z35aVWFvW6051b0yJwB4+kRu6Tm+H9qwa9AYYdx4Fz2mg41MX1ffrWcrSMaw/KHVz2Yq TfsQ8z+1tjOL18Af5FLljhy2ggO23b82qurbzvHrc2Dce+KTPSsW7bTY7Bc1FD/DTaF2 6JYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s30-20020a63ff5e000000b0041293fa551esi1050942pgk.580.2022.08.26.00.33.45; Fri, 26 Aug 2022 00:33:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245288AbiHZH0P (ORCPT + 99 others); Fri, 26 Aug 2022 03:26:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245275AbiHZH0I (ORCPT ); Fri, 26 Aug 2022 03:26:08 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 893B64A82E for ; Fri, 26 Aug 2022 00:25:59 -0700 (PDT) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MDWW52CMWzkWJX; Fri, 26 Aug 2022 15:22:25 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 26 Aug 2022 15:25:58 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 26 Aug 2022 15:25:57 +0800 From: Yang Yingliang To: CC: , , , Subject: [PATCH -next 1/3] fail_function: Switch to memdup_user_nul() helper Date: Fri, 26 Aug 2022 15:33:35 +0800 Message-ID: <20220826073337.2085798-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by: Yang Yingliang --- kernel/fail_function.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/kernel/fail_function.c b/kernel/fail_function.c index 60dc825ecc2b..03643e33e4c3 100644 --- a/kernel/fail_function.c +++ b/kernel/fail_function.c @@ -247,15 +247,11 @@ static ssize_t fei_write(struct file *file, const char __user *buffer, /* cut off if it is too long */ if (count > KSYM_NAME_LEN) count = KSYM_NAME_LEN; - buf = kmalloc(count + 1, GFP_KERNEL); - if (!buf) - return -ENOMEM; - if (copy_from_user(buf, buffer, count)) { - ret = -EFAULT; - goto out_free; - } - buf[count] = '\0'; + buf = memdup_user_nul(buffer, count); + if (IS_ERR(buf)) + return PTR_ERR(buf); + sym = strstrip(buf); mutex_lock(&fei_lock); @@ -308,7 +304,6 @@ static ssize_t fei_write(struct file *file, const char __user *buffer, } out: mutex_unlock(&fei_lock); -out_free: kfree(buf); return ret; } -- 2.25.1