Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp92842rwe; Fri, 26 Aug 2022 01:03:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR4U/po8ZJNYk6t0quTf9rg3IfX2VMV6joMG6Q3Qf/Gnz1f6v93ty4uZONYnDk9XDnkLrnk7 X-Received: by 2002:a17:90a:c70e:b0:1fb:c116:5347 with SMTP id o14-20020a17090ac70e00b001fbc1165347mr3109858pjt.40.1661501032868; Fri, 26 Aug 2022 01:03:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661501032; cv=none; d=google.com; s=arc-20160816; b=wBe2JohyCjjroTkBfRBPEJYiLUVDebDAlCnVnWI+4NJrrUqeGje4R/clFJQQ3pVzCw 5tfvMJMXA8bkb8yelhQsdrRG8tcZoI73zER0EniwTfIObSNVWFLVzxGHq5T3pP8YWOje mHA2LHuPmDyXPIzeNdYUZcmzDkUOFhX0GGPm6LrrsWDjriCuKv9ZKoYsbW//m/4UalWm puDl8smEQce59XPJAWyrugWrJprLPj6uhdzDnfsCilKsbtYxt1oYmZFH3CkLJVFj1y2A oCzYMnP3+fgpqRAltbj9DTNR+arvcwwi0yij5clSJjyJuiiGSQVQJG7+m0yMdItP+kFZ aHrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EpkxN5EAP9ylDf26WrLrt45Zu64Nr8Hgt4w4AnXI7Jg=; b=w8zEmZAxkjtwZevJJUOvfurtbrN3jaVd9gomGXv3Q4teJOMxCOw6N6IuPu8V3CIRmb EMYcyNT4AWa8/tBX0Z715AdtpOYE65mMVAfu/SYIK8kqBfIBhNM7Vk9OJsnnFeiKRDO0 pcs6rhLl57Bvf2xT4GpquyM8QcdKNa+rdcD4GkMpaUyOfvuFMKm9l961aWxXL8ca8B5T hyVFzC2QPGHdC5F6NMbAilZ+pKjreAPCSpt63gAGz4WT8mJlRY05HwuV27YjePkQqY+Z ShFXOlEgMGUiwpKFnm+ruIzRYpMmw3Yv5ZumPNiPeM3+KvbdLCzEcx08XR0F4BFyUk3m mgEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a056a0000c400b00536fefde5cbsi1158445pfj.129.2022.08.26.01.03.40; Fri, 26 Aug 2022 01:03:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245270AbiHZH0L (ORCPT + 99 others); Fri, 26 Aug 2022 03:26:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245273AbiHZH0I (ORCPT ); Fri, 26 Aug 2022 03:26:08 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89AC54AD50 for ; Fri, 26 Aug 2022 00:26:00 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MDWXT2LMPzmVWt; Fri, 26 Aug 2022 15:23:37 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 26 Aug 2022 15:25:58 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 26 Aug 2022 15:25:58 +0800 From: Yang Yingliang To: CC: , , , Subject: [PATCH -next 2/3] fail_function: refctor code of checking return value of register_kprobe() Date: Fri, 26 Aug 2022 15:33:36 +0800 Message-ID: <20220826073337.2085798-2-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220826073337.2085798-1-yangyingliang@huawei.com> References: <20220826073337.2085798-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Refactor the error handling of register_kprobe() to improve readability. No functional change. Signed-off-by: Yang Yingliang --- kernel/fail_function.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/kernel/fail_function.c b/kernel/fail_function.c index 03643e33e4c3..893e8f9a9118 100644 --- a/kernel/fail_function.c +++ b/kernel/fail_function.c @@ -294,14 +294,13 @@ static ssize_t fei_write(struct file *file, const char __user *buffer, } ret = register_kprobe(&attr->kp); - if (!ret) - fei_debugfs_add_attr(attr); - if (ret < 0) + if (ret) { fei_attr_remove(attr); - else { - list_add_tail(&attr->list, &fei_attr_list); - ret = count; + goto out; } + fei_debugfs_add_attr(attr); + list_add_tail(&attr->list, &fei_attr_list); + ret = count; out: mutex_unlock(&fei_lock); kfree(buf); -- 2.25.1