Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ming Qian <ming.qian@nxp.com>
To:     Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
CC:     "mchehab@kernel.org" <mchehab@kernel.org>,
        "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "X.H. Bao" <xiahong.bao@nxp.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v5 2/4] media: amphion: tell and handle
 contiguous and non contiguous format
Thread-Topic: [EXT] Re: [PATCH v5 2/4] media: amphion: tell and handle
 contiguous and non contiguous format
Thread-Index: AQHYuCHju+FVuKkz9ki0/lyYsF8uQK3AyHWAgAAGC2A=
Date:   Fri, 26 Aug 2022 07:47:47 +0000
Message-ID: <AM6PR04MB634128ED70894F35B629C69AE7759@AM6PR04MB6341.eurprd04.prod.outlook.com>
References: <cover.1661390673.git.ming.qian@nxp.com>
 <7e6a945b898254679bd93e7e001e7c24b5aea0ef.1661390673.git.ming.qian@nxp.com>
 <20220826072047.GA3151@tom-ThinkPad-T14s-Gen-2i>
In-Reply-To: <20220826072047.GA3151@tom-ThinkPad-T14s-Gen-2i>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NK+KO2WhoWAoAtgwKwNXfSYARYO+F23Yl9tAinN/2sCgsaF1FEqsWyUiWQBk?=
 =?us-ascii?Q?O5QtSBGv5xHi05g5nBV4WkaoktpCy3SXs9ERVQMsU9Y2/TxXGXWqQ7eOTmUM?=
 =?us-ascii?Q?/6EnJqdi9mwEGOH43LrjJP2yVfEhqW7Xab5b+W+2+ZHankWyC5aZkfCaHZxO?=
 =?us-ascii?Q?7VbXvYT2C2QpPj1x1cCKxjkIa1c/SkivpsvtCudsh2QcaLsXCwNZzncEq3I7?=
 =?us-ascii?Q?sVxGaiQYVvW4DWIylZeVVVimYOsuOLnZCDNGmz9l81DDcJ/ShD+Dj3cTmQUH?=
 =?us-ascii?Q?TJcnSjdkHxC2UayFiLlzP/JvKY9RiQI0NLg454QdvnaelQMfQFgpppQvq8hX?=
 =?us-ascii?Q?9wWgMNHby/XwCsHGx6povZq+RUaojfn0kEDn3nhkEnUI5psf7YLEkZ57Lswu?=
 =?us-ascii?Q?txC1s9d0uRfqp7HpJAzusoW4lLqfn/vuMyh07NrzpxiOo2X+TYhZu0McWluW?=
 =?us-ascii?Q?fa1/LTIddt/wZLufb83RKQGZMdoTgdM8FTM7qrL/Tso0vjPLdRC2m+NA5hJE?=
 =?us-ascii?Q?6TdwrbvEvADwEwWCKTufYOMjH1zmFmgbXANrMoEUFuGUXgb9DaTAUcl0JpgB?=
 =?us-ascii?Q?lqRsUuYVbb0/tBUqlkW6hnjZjYVk/N3oSrKpfcP1kj13+ljOzoC3c7AsxxSL?=
 =?us-ascii?Q?YfPfbYdpcF3UFkw7xcLtn/MxTMxC2S5FTWnm7rjiFFQWSV8rwFA9GNrXDykO?=
 =?us-ascii?Q?07J+/2F8j9yANFKeWmjN4ca7nRbt0FT98hU6TDkMr4qqZFUNJ119Zs2huIt1?=
 =?us-ascii?Q?LBt3cVr10LQ3MBeLw0nF396a0iiIAqJiEEgCzLXmLyZpOliTtT1dXR682gxl?=
 =?us-ascii?Q?ejZds/ulm58RgZ8/we5tl9C+qgPesTn5oVBFoIabbk0wIqqA9bhJy6Ybvu0q?=
 =?us-ascii?Q?F37q0mGmKF1HFMd0qC06ELno/UJ6ew2NsmH0SZJ1xl1+VMSHylV3HTp2yHW3?=
 =?us-ascii?Q?LCs4Rh7KoJwm+nD7mIBGWLT55BRqzE7r4WzVG8qT+kXeBSXZZm096m4S1QmJ?=
 =?us-ascii?Q?fmH3uabmDTjNac0ZIMeyfn/Nb54pHHfZydb2e1ryYOBujngMTujx4vjCBzkz?=
 =?us-ascii?Q?FsV+KpCFF/G0+YcaQdq0aokJ6XwBPKcEW7MxXdla9XmVsx/Bw71IaZE47Hd0?=
 =?us-ascii?Q?nVJbeyoaNt8/kBY9hXYQD7qoaHHlXZmq7dVoX/mtCR/3YplzE0rYNWMLOv7i?=
 =?us-ascii?Q?Nc8t9GXZ8sWMPYaL8+A/O0Y8DOhCX7dyxhaz+Bk2DEg5vF/gM+iwnJeWSPvb?=
 =?us-ascii?Q?8Fq8xCpKRHF8gmIB7eQtWVWb/9QhMA4Gi4xhe562ZGQ/YDXIBQ8fSX6FmFn7?=
 =?us-ascii?Q?0TifjM8RxChFuMuXtwOKiDikVIwXMMhYWVNKmIOTikTBV1RtkvXsJZXmZnM0?=
 =?us-ascii?Q?msX9ACpQ6cBFRcAwFZhk9/oogHCnetRH7R+8tdsBGp6EZDIjvbzvvbNBCPNr?=
 =?us-ascii?Q?4gla9+KFUvZjtvNkDOAkazQ9QiDbZz9cXrpt2qJywW53POms6/ZQajEHMwrp?=
 =?us-ascii?Q?FSJzCHbsbQ8LzT+sYNV2138xGEkI1ifewLF3BYngYVNNtQkyzEbRMrZROpIe?=
 =?us-ascii?Q?jzasg88zWKVaschbTW8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb32daae-4be8-4d8b-76f4-08da8737451c
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 07:47:47.8322
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W/StMUNNLVnB6mnw4//PpZfPnHRY4I2IP+LUIUi1OuwiLwuHdf8GSFxendqHkxmyb9ixYCII75cTLNVJkbJYag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[snip]

>> diff --git a/drivers/media/platform/amphion/vpu_helpers.c
>> b/drivers/media/platform/amphion/vpu_helpers.c
>> index e9aeb3453dfc..019c77e84514 100644
>> --- a/drivers/media/platform/amphion/vpu_helpers.c
>> +++ b/drivers/media/platform/amphion/vpu_helpers.c
>> @@ -59,6 +59,36 @@ const struct vpu_format
>*vpu_helper_find_format(struct vpu_inst *inst, u32 type,
>>       return NULL;
>>  }
>>
>> +const struct vpu_format *vpu_helper_find_sibling(struct vpu_inst
>> +*inst, u32 type, u32 pixelfmt) {
>> +     const struct vpu_format *fmt;
>> +     const struct vpu_format *sibling;
>> +
>> +     fmt =3D vpu_helper_find_format(inst, type, pixelfmt);
>> +     if (!fmt || !fmt->sibling)
>> +             return NULL;
>> +
>> +     sibling =3D vpu_helper_find_format(inst, type, fmt->sibling);
>> +     if (!sibling || sibling->sibling !=3D fmt->pixfmt ||
>> +         sibling->comp_planes !=3D fmt->comp_planes)
>> +             return NULL;
>
>I think to preserve code style you need the following solutions on this if
>statement:
>
>if (!sibling || (sibling->sibling !=3D fmt->pixfmt) ||
>    (sibling->comp_planes !=3D fmt->comp_planes))
>         return NULL;
>
>I think I have suggested to you this solution on the v4. But never mind we
>need this :)
>
>Thanks
>

Hi Tommaso,
    The parentheses are unnecessary, the checkpatch.pl will report the foll=
owing style problems if I add the parentheses:

CHECK: Unnecessary parentheses around 'sibling->sibling !=3D fmt->pixfmt'
#11: FILE: drivers/media/platform/amphion/vpu_helpers.c:72:
+       if (!sibling || (sibling->sibling !=3D fmt->pixfmt) ||
+           (sibling->comp_planes !=3D fmt->comp_planes))

CHECK: Unnecessary parentheses around 'sibling->comp_planes !=3D fmt->comp_=
planes'
#11: FILE: drivers/media/platform/amphion/vpu_helpers.c:72:
+       if (!sibling || (sibling->sibling !=3D fmt->pixfmt) ||
+           (sibling->comp_planes !=3D fmt->comp_planes))

total: 0 errors, 0 warnings, 2 checks, 10 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplac=
e.

1.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.