Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1fa01bcf-15e5-279e-79ac-056c70a9401d@huawei.com>
Date:   Fri, 26 Aug 2022 15:45:43 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH] rtc: fsl-ftm-alarm: Use module_init and add module_exit
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
CC:     <a.zummo@towertech.it>, <linux-rtc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220826070017.2340617-1-chris.zjh@huawei.com>
 <Ywh00crgSilSfZnC@mail.local>
From:   "zhangjianhua (E)" <chris.zjh@huawei.com>
In-Reply-To: <Ywh00crgSilSfZnC@mail.local>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/8/26 15:22, Alexandre Belloni 写道:
> On 26/08/2022 15:00:17+0800, Zhang Jianhua wrote:
>> - Use module_init instead of device_initcall.
>> - Add a function for module_exit to unregister driver.
>>
> I can see what you are doing but this doesn't explain why. Also, was
> this tested on any actual hardware?

I find this problem by code review, so solve it smoothly, and there is 
no hardware, so I just test it on qemu.

May I need to modify the commit message?

>> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
>> ---
>>   drivers/rtc/rtc-fsl-ftm-alarm.c | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
>> index c0df49fb978c..28bdc6c97b64 100644
>> --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
>> +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
>> @@ -332,7 +332,13 @@ static int __init ftm_alarm_init(void)
>>   	return platform_driver_register(&ftm_rtc_driver);
>>   }
>>   
>> -device_initcall(ftm_alarm_init);
>> +static void __exit ftm_alarm_exit(void)
>> +{
>> +	platform_driver_unregister(&ftm_rtc_driver);
>> +}
>> +
>> +module_init(ftm_alarm_init)
>> +module_exit(ftm_alarm_exit)
>>   
>>   MODULE_DESCRIPTION("NXP/Freescale FlexTimer alarm driver");
>>   MODULE_AUTHOR("Biwen Li <biwen.li@nxp.com>");
>> -- 
>> 2.31.0
>>