Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220817080757.352021-1-bchihi@baylibre.com> <20220817080757.352021-5-bchihi@baylibre.com>
 <05fa19f7-7997-51c3-767f-c40cb321d2a4@linaro.org>
In-Reply-To: <05fa19f7-7997-51c3-767f-c40cb321d2a4@linaro.org>
From:   Balsam CHIHI <bchihi@baylibre.com>
Date:   Fri, 26 Aug 2022 10:05:52 +0200
Message-ID: <CAGuA+opoKKvQvC0aij_L1t8BQG2rHJDwx-U=XjgvaqK5Bg-WdQ@mail.gmail.com>
Subject: Re: [PATCH v9,4/7] thermal: mediatek: Add LVTS driver for mt8192
 thermal zones
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, rui.zhang@intel.com, amitk@kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org,
        krzk+dt@kernel.org, matthias.bgg@gmail.com, p.zabel@pengutronix.de,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, james.lo@mediatek.com,
        fan.chen@mediatek.com, louis.yu@mediatek.com,
        rex-bc.chen@mediatek.com, abailon@baylibre.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Daniel,

Thank you for the feedback.

I hope this information will explain better the LVTS Driver.
I will add this like the following.
Is this ok for you?

[v9,7/7] thermal: mediatek: Add LVTS driver settings for mt8195 thermal zon=
es
One Clock and one Reset for Thermal.
Thermal have two domain : CPU related (mcu) and non-CPU related (ap).
TC : Thermal Controller to control the thermal sensor's HW behavior.
TS : Thermal Sensor for measuring temperature the HW module.
thermal
=E2=94=9C=E2=94=80=E2=94=80 ap
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 tc_0
=E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS4_0 - vpu1
=E2=94=82 =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS4_1 - vpu2
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 tc_1
=E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS5_0 - gpu1
=E2=94=82 =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS5_1 - gpu2
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 tc_2
=E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS6_0 - vdec
=E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS6_1 - img
=E2=94=82 =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS6_2 - infra
=E2=94=82 =E2=94=94=E2=94=80=E2=94=80 tc_3
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS7_0 - cam1
=E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS7_1 - cam2
=E2=94=94=E2=94=80=E2=94=80 mcu
=E2=94=9C=E2=94=80=E2=94=80 tc_0
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS1_0 - cpu_big1
=E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS1_1 - cpu_big2
=E2=94=9C=E2=94=80=E2=94=80 tc_1
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS2_0 - cpu_big3
=E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS2_1 - cpu_big4
=E2=94=94=E2=94=80=E2=94=80 tc_2
=E2=94=9C=E2=94=80=E2=94=80 TS3_0 - cpu_little1
=E2=94=9C=E2=94=80=E2=94=80 TS3_1 - cpu_little2
=E2=94=9C=E2=94=80=E2=94=80 TS3_2 - cpu_little3
=E2=94=94=E2=94=80=E2=94=80 TS3_3 - cpu_little4

[v9,4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones
One Clock and one Reset for Thermal.
Thermal have two domain : CPU related (mcu) and non-CPU related (ap).
TC : Thermal Controller to control the thermal sensor's HW behavior.
TS : Thermal Sensor for measuring temperature the HW module.
thermal
=E2=94=9C=E2=94=80=E2=94=80 ap
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 tc_0
=E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS4_0 - vpu1
=E2=94=82 =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS4_1 - vpu2
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 tc_1
=E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS5_0 - gpu1
=E2=94=82 =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS5_1 - gpu2
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 tc_2
=E2=94=82 =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS6_0 - infra
=E2=94=82 =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS6_1 - cam
=E2=94=82 =E2=94=94=E2=94=80=E2=94=80 tc_3
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS7_0 - md2
=E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS7_1 - md3
| =E2=94=94=E2=94=80=E2=94=80 TS6_2 - md1
=E2=94=94=E2=94=80=E2=94=80 mcu
=E2=94=9C=E2=94=80=E2=94=80 tc_0
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS1_0 - cpu_big1
=E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS1_1 - cpu_big2
=E2=94=9C=E2=94=80=E2=94=80 tc_1
=E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 TS2_0 - cpu_big3
=E2=94=82 =E2=94=94=E2=94=80=E2=94=80 TS2_1 - cpu_big4
=E2=94=94=E2=94=80=E2=94=80 tc_2
=E2=94=9C=E2=94=80=E2=94=80 TS3_0 - cpu_little1
=E2=94=9C=E2=94=80=E2=94=80 TS3_1 - cpu_little2
=E2=94=9C=E2=94=80=E2=94=80 TS3_2 - cpu_little3
=E2=94=94=E2=94=80=E2=94=80 TS3_3 - cpu_little4

Best regards,
Balsam.

On Thu, Aug 25, 2022 at 7:29 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
>
> Hi Balsam,
>
> On 17/08/2022 10:07, bchihi@baylibre.com wrote:
> > From: Michael Kao <michael.kao@mediatek.com>
> >
> > Add LVTS v4 (Low Voltage Thermal Sensor) driver to report junction
> > temperatures in MediaTek SoC mt8192 and register the maximum temperatur=
e
> > of sensors and each sensor as a thermal zone.
>
> Thanks for your work
>
> First of all, the patch is way too big.
>
> The organization of the data is hard to understand.
>
> Could you give a description of the sensors, how they are organized ?
>
> I can see the there are 'tc' and each have a group of sensing points? Is
> that correct? Do have the 'tc's a shared clock? etc ...
>
> I have another email with the comments inline but without more insights
> on the hardware it is difficult to review accurately. This driver looks
> more complex than the other ones I've reviewed. At least that is what
> looks like with the different macros names found.
>
>
>
> --
> <http://www.linaro.org/> Linaro.org =E2=94=82 Open source software for AR=
M SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog